assert: fix loose assert with map and set

There was an oversight when checking the possible loose comparisons. This is now fixed by also accepting `''` instead of `0` or `false`. PR-URL: #22145 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Author: BridgeAR

lib/internal/util/comparisons.js

@@ -354,29 +354,38 @@ function setEquiv(a, b, strict, memo){
 returntrue;
 }
 
+// See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness#Loose_equality_using
 functionfindLooseMatchingPrimitives(prim){
-varvalues,number;
 switch(typeofprim){
 case'number':
-values=[''+prim];
-if(prim===1||prim===0)
-values.push(Boolean(prim));
-returnvalues;
+if(prim===0){
+return['','0',false];
+}
+if(prim===1){
+return['1',true];
+}
+return[''+prim];
 case'string':
-number=+prim;
+if(prim===''||prim==='0'){
+return[0,false];
+}
+if(prim==='1'){
+return[1,true];
+}
+constnumber=+prim;
 if(''+number===prim){
-values=[number];
-if(number===1||number===0)
-values.push(Boolean(number));
+return[number];
 }
-returnvalues;
+return;
 case'undefined':
 return[null];
 case'object': // Only pass in null as object!
 return[undefined];
 case'boolean':
-number=+prim;
-return[number,''+number];
+if(prim===false){
+return['','0',0];
+}
+return['1',1];
 }
 }
 

test/parallel/test-assert-deep.js

@@ -350,8 +350,8 @@ assertDeepAndStrictEqual(
 newMap([[1,undefined]])
 );
 assertOnlyDeepEqual(
-newMap([[1,null]]),
-newMap([['1',undefined]])
+newMap([[1,null],['','0']]),
+newMap([['1',undefined],[false,0]])
 );
 assertNotDeepOrStrict(
 newMap([[1,undefined]]),
@@ -368,8 +368,12 @@ assertOnlyDeepEqual(
 newMap([[undefined,null]])
 );
 assertOnlyDeepEqual(
-newSet([null]),
-newSet([undefined])
+newSet([null,'']),
+newSet([undefined,0])
+);
+assertNotDeepOrStrict(
+newSet(['']),
+newSet(['0'])
 );
 
 // GH-6416. Make sure circular refs don't throw.