fs: use consistent buffer array validation

This commit updates fs.writev() and fs.writevSync() to use the same validation method as filehandle.writev(). PR-URL: #29186 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

lib/fs.js

@@ -72,6 +72,7 @@ const{
  stringToFlags,
  stringToSymlinkType,
  toUnixTimestamp,
+ validateBufferArray,
  validateOffsetLengthRead,
  validateOffsetLengthWrite,
  validatePath,
@@ -142,19 +143,6 @@ function maybeCallback(cb){
 thrownewERR_INVALID_CALLBACK(cb);
 }
 
-functionisBuffersArray(value){
-if(!Array.isArray(value))
-returnfalse;
-
-for(vari=0;i<value.length;i+=1){
-if(!isArrayBufferView(value[i])){
-returnfalse;
-}
-}
-
-returntrue;
-}
-
 // Ensure that callbacks run in the global context. Only use this function
 // for callbacks that are passed to the binding layer, callbacks that are
 // invoked from JS already run in the proper scope.
@@ -610,10 +598,7 @@ function writev(fd, buffers, position, callback){
 }
 
 validateInt32(fd,'fd',0);
-
-if(!isBuffersArray(buffers)){
-thrownewERR_INVALID_ARG_TYPE('buffers','ArrayBufferView[]',buffers);
-}
+validateBufferArray(buffers);
 
 constreq=newFSReqCallback();
 req.oncomplete=wrapper;
@@ -631,15 +616,11 @@ Object.defineProperty(writev, internalUtil.customPromisifyArgs,{
 enumerable: false
 });
 
-// fs.writevSync(fd, buffers[, position]);
 functionwritevSync(fd,buffers,position){
-
 validateInt32(fd,'fd',0);
-constctx={};
+validateBufferArray(buffers);
 
-if(!isBuffersArray(buffers)){
-thrownewERR_INVALID_ARG_TYPE('buffers','ArrayBufferView[]',buffers);
-}
+constctx={};
 
 if(typeofposition!=='number')
 position=null;