src: add virtual desctructor to Options class

Currently the Options class has a virtual function but no virtual destructor which means that if delete is called on a Options pointer to a derived instance, the derived destructor will not get called. The following warning is currently being printed when compiling: warning: delete called on non-final 'node::PerIsolateOptions' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] delete __ptr; This commit adds a virtual destructor. PR-URL: #23215 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: danbev

src/node_options.h

@@ -24,6 +24,7 @@ struct HostPort{
 classOptions{
 public:
 virtualvoidCheckOptions(std::vector<std::string>* errors){}
+virtual~Options(){}
 };
 
 // These options are currently essentially per-Environment, but it can be nice