test: fix flaky test-https-timeout

Remove `setTimeout()` in test and instead rely on `common.mustCall()` on a `timeout` event handler. The test was flaky on CI. The flakiness was replicable by running the test under load. This version, in contrast, is robust under load. Took the opportunity to do some `var` -> `const` while refactoring. PR-URL: #10404 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Trott

test/parallel/test-https-timeout.js

@@ -1,24 +1,24 @@
 'use strict';
-varcommon=require('../common');
+constcommon=require('../common');
 
 if(!common.hasCrypto){
 common.skip('missing crypto');
 return;
 }
-varhttps=require('https');
+consthttps=require('https');
 
-varfs=require('fs');
+constfs=require('fs');
 
-varoptions={
+constoptions={
 key: fs.readFileSync(common.fixturesDir+'/keys/agent1-key.pem'),
 cert: fs.readFileSync(common.fixturesDir+'/keys/agent1-cert.pem')
 };
 
 // a server that never replies
-varserver=https.createServer(options,function(){
+constserver=https.createServer(options,function(){
 console.log('Got request. Doing nothing.');
-}).listen(0,function(){
-varreq=https.request({
+}).listen(0,common.mustCall(function(){
+constreq=https.request({
 host: 'localhost',
 port: this.address().port,
 path: '/',
@@ -28,26 +28,14 @@ var server = https.createServer(options, function(){
 req.setTimeout(10);
 req.end();
 
-req.on('response',function(res){
+req.on('response',function(){
 console.log('got response');
 });
 
-req.on('socket',function(){
-console.log('got a socket');
-
-req.socket.on('connect',function(){
-console.log('socket connected');
-});
-
-setTimeout(function(){
-thrownewError('Did not get timeout event');
-},200);
-});
-
-req.on('timeout',function(){
+req.on('timeout',common.mustCall(function(){
 console.log('timeout occurred outside');
 req.destroy();
 server.close();
 process.exit(0);
-});
-});
+}));
+}));