test: remove common.PORT from parallel tests

`common.PORT` should not be used in parallel tests because another test may experience a collision with `common.PORT` when using port 0 to get an open port. This has been observed to result in test failures in CI. PR-URL: #17410 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Author: Trott

test/async-hooks/test-graph.tcp.js

@@ -15,7 +15,7 @@ const server = net
 .createServer(common.mustCall(onconnection))
 .on('listening',common.mustCall(onlistening));
 
-server.listen(common.PORT);
+server.listen(0);
 
 net.connect({port: server.address().port,host: '::1'},
 common.mustCall(onconnected));

test/async-hooks/test-graph.tls-write.js

@@ -25,14 +25,14 @@ const server = tls
 })
 .on('listening',common.mustCall(onlistening))
 .on('secureConnection',common.mustCall(onsecureConnection))
-.listen(common.PORT);
+.listen(0);
 
 functiononlistening(){
 //
 // Creating client and connecting it to server
 //
 tls
-.connect(common.PORT,{rejectUnauthorized: false})
+.connect(server.address().port,{rejectUnauthorized: false})
 .on('secureConnect',common.mustCall(onsecureConnect));
 }
 

test/async-hooks/test-tcpwrap.js

@@ -24,7 +24,7 @@ const server = net
 
 // Calling server.listen creates a TCPWRAP synchronously
 {
-server.listen(common.PORT);
+server.listen(0);
 consttcpsservers=hooks.activitiesOfTypes('TCPSERVERWRAP');
 consttcpconnects=hooks.activitiesOfTypes('TCPCONNECTWRAP');
 assert.strictEqual(tcpsservers.length,1);

test/async-hooks/test-writewrap.js

@@ -23,7 +23,7 @@ const server = tls
 })
 .on('listening',common.mustCall(onlistening))
 .on('secureConnection',common.mustCall(onsecureConnection))
-.listen(common.PORT);
+.listen(0);
 
 assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length,0);
 
@@ -33,7 +33,7 @@ function onlistening(){
 // Creating client and connecting it to server
 //
 tls
-.connect(common.PORT,{rejectUnauthorized: false})
+.connect(server.address().port,{rejectUnauthorized: false})
 .on('secureConnect',common.mustCall(onsecureConnect));
 
 assert.strictEqual(hooks.activitiesOfTypes('WRITEWRAP').length,0);

test/parallel/test-net-connect-immediate-finish.js

@@ -38,9 +38,9 @@ const{
 
 constclient=net.connect({
 host: addresses.INVALID_HOST,
-port: common.PORT,
+port: 80,// port number doesn't matter because host name is invalid
 lookup: common.mustCall(errorLookupMock())
-});
+},common.mustNotCall());
 
 client.once('error',common.mustCall((err)=>{
 assert(err);