process: do not lazily load AsyncResource

targos · jasnell · commit 8dd5dd8a4b99 · 2021-04-06T07:46:45.000-07:00
It doesn't seem necessary. PR-URL: #38041 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js
@@ -40,6 +40,8 @@ const{
 validateFunction,
 } = require('internal/validators');
 
+const{AsyncResource } = require('async_hooks');
+
 // *Must* match Environment::TickInfo::Fields in src/env.h.
 const kHasTickScheduled = 0;
 
@@ -132,16 +134,6 @@ function nextTick(callback){
 queue.push(tickObject);
 }
 
-let AsyncResource;
-const defaultMicrotaskResourceOpts ={requireManualDestroy: true };
-function createMicrotaskResource(){
- // Lazy load the async_hooks module
- if (AsyncResource === undefined){
- AsyncResource = require('async_hooks').AsyncResource;
- }
- return new AsyncResource('Microtask', defaultMicrotaskResourceOpts);
-}
-
 function runMicrotask(){
 this.runInAsyncScope(() =>{
 const callback = this.callback;
@@ -153,10 +145,15 @@ function runMicrotask(){
 });
 }
 
+const defaultMicrotaskResourceOpts ={requireManualDestroy: true };
+
 function queueMicrotask(callback){
 validateFunction(callback, 'callback');
 
- const asyncResource = createMicrotaskResource();
+ const asyncResource = new AsyncResource(
+ 'Microtask',
+ defaultMicrotaskResourceOpts
+ );
 asyncResource.callback = callback;
 
 enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));

-Original file line number
+Diff line change
  validateFunction,
 }=require('internal/validators');
 +const{ AsyncResource }=require('async_hooks');
++
 // *Must* match Environment::TickInfo::Fields in src/env.h.
 constkHasTickScheduled=0;
 queue.push(tickObject);
+}
 -letAsyncResource;
 -constdefaultMicrotaskResourceOpts={requireManualDestroy: true};
 -functioncreateMicrotaskResource(){
 -// Lazy load the async_hooks module
 -if(AsyncResource===undefined){
 -AsyncResource=require('async_hooks').AsyncResource;
 -}
 -returnnewAsyncResource('Microtask',defaultMicrotaskResourceOpts);
 -}
+-
 functionrunMicrotask(){
 this.runInAsyncScope(()=>{
 constcallback=this.callback;
 });
+}
 +constdefaultMicrotaskResourceOpts={requireManualDestroy: true};
++
 functionqueueMicrotask(callback){
 validateFunction(callback,'callback');
 -constasyncResource=createMicrotaskResource();
 +constasyncResource=newAsyncResource(
 +'Microtask',
 +defaultMicrotaskResourceOpts
 +);
 asyncResource.callback=callback;
 enqueueMicrotask(FunctionPrototypeBind(runMicrotask,asyncResource));