test: use Countdown in http-response-statuscode

daxlab · gibfahn · commit 90ee2b56576c · 2017-12-20T02:00:50.000Z
PR-URL: #17327 Refs: #17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
diff --git a/test/parallel/test-http-response-statuscode.js b/test/parallel/test-http-response-statuscode.js
@@ -2,6 +2,7 @@
 const common = require('../common');
 const assert = require('assert');
 const http = require('http');
+const Countdown = require('../common/countdown');
 
 const MAX_REQUESTS = 13;
 let reqNum = 0;
@@ -64,13 +65,17 @@ const server = http.Server(common.mustCall(function(req, res){
 }, MAX_REQUESTS));
 server.listen();
 
+const countdown = new Countdown(MAX_REQUESTS, () => server.close());
+
 server.on('listening', function makeRequest(){
 http.get({
 port: this.address().port
 }, (res) =>{
 assert.strictEqual(res.statusCode, 200);
 res.on('end', () =>{
- if (++reqNum < MAX_REQUESTS)
+ countdown.dec();
+ reqNum = MAX_REQUESTS - countdown.remaining;
+ if (countdown.remaining > 0)
 makeRequest.call(this);
 });
 res.resume();

-Original file line number
+Diff line change
 constcommon=require('../common');
 constassert=require('assert');
 consthttp=require('http');
 +constCountdown=require('../common/countdown');
 constMAX_REQUESTS=13;
 letreqNum=0;
 },MAX_REQUESTS));
 server.listen();
 +constcountdown=newCountdown(MAX_REQUESTS,()=>server.close());
++
 server.on('listening',functionmakeRequest(){
 http.get({
 port: this.address().port
 },(res)=>{
 assert.strictEqual(res.statusCode,200);
 res.on('end',()=>{
 -if(++reqNum<MAX_REQUESTS)
 +countdown.dec();
 +reqNum=MAX_REQUESTS-countdown.remaining;
 +if(countdown.remaining>0)
 makeRequest.call(this);
 });
 res.resume();