http: change DEP0066 to a runtime deprecation

Change doc-only deprecation for _headers and _headerNames accessors to a runtime deprecation. PR-URL: #24167 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Author: mroderick

doc/api/deprecations.md

@@ -1344,12 +1344,15 @@ removed. Please use `sloppy` instead.
 ### DEP0066: outgoingMessage.\_headers, outgoingMessage.\_headerNames
 <!-- YAML
 changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/24167
+ description: Runtime deprecation.
  - version: v8.0.0
  pr-url: https://github.com/nodejs/node/pull/10941
  description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime
 
 The `http` module `outgoingMessage._headers` and `outgoingMessage._headerNames`
 properties are deprecated. Use one of the public methods

lib/_http_outgoing.js

@@ -110,10 +110,10 @@ util.inherits(OutgoingMessage, Stream);
 
 
 Object.defineProperty(OutgoingMessage.prototype,'_headers',{
-get: function(){
+get: util.deprecate(function(){
 returnthis.getHeaders();
-},
-set: function(val){
+},'OutgoingMessage.prototype._headers is deprecated','DEP0066'),
+set: util.deprecate(function(val){
 if(val==null){
 this[outHeadersKey]=null;
 }elseif(typeofval==='object'){
@@ -124,11 +124,11 @@ Object.defineProperty(OutgoingMessage.prototype, '_headers',{
 headers[name.toLowerCase()]=[name,val[name]];
 }
 }
-}
+},'OutgoingMessage.prototype._headers is deprecated','DEP0066')
 });
 
 Object.defineProperty(OutgoingMessage.prototype,'_headerNames',{
-get: function(){
+get: util.deprecate(function(){
 constheaders=this[outHeadersKey];
 if(headers!==null){
 constout=Object.create(null);
@@ -141,8 +141,8 @@ Object.defineProperty(OutgoingMessage.prototype, '_headerNames',{
 returnout;
 }
 returnnull;
-},
-set: function(val){
+},'OutgoingMessage.prototype._headerNames is deprecated','DEP0066'),
+set: util.deprecate(function(val){
 if(typeofval==='object'&&val!==null){
 constheaders=this[outHeadersKey];
 if(!headers)
@@ -154,7 +154,7 @@ Object.defineProperty(OutgoingMessage.prototype, '_headerNames',{
 header[0]=val[keys[i]];
 }
 }
-}
+},'OutgoingMessage.prototype._headerNames is deprecated','DEP0066')
 });
 
 

test/parallel/test-http-outgoing-internal-headernames-getter.js

@@ -0,0 +1,13 @@
+'use strict';
+constcommon=require('../common');
+
+const{ OutgoingMessage }=require('http');
+
+constwarn='OutgoingMessage.prototype._headerNames is deprecated';
+common.expectWarning('DeprecationWarning',warn,'DEP0066');
+
+{
+// tests for _headerNames get method
+constoutgoingMessage=newOutgoingMessage();
+outgoingMessage._headerNames;
+}

test/parallel/test-http-outgoing-internal-headernames-setter.js

@@ -0,0 +1,15 @@
+'use strict';
+constcommon=require('../common');
+
+const{ OutgoingMessage }=require('http');
+
+constwarn='OutgoingMessage.prototype._headerNames is deprecated';
+common.expectWarning('DeprecationWarning',warn,'DEP0066');
+
+{
+// tests for _headerNames set method
+constoutgoingMessage=newOutgoingMessage();
+outgoingMessage._headerNames={
+'x-flow-id': '61bba6c5-28a3-4eab-9241-2ecaa6b6a1fd'
+};
+}

test/parallel/test-http-outgoing-internal-headers.js

@@ -6,6 +6,9 @@ const assert = require('assert');
 const{ outHeadersKey }=require('internal/http');
 const{ OutgoingMessage }=require('http');
 
+constwarn='OutgoingMessage.prototype._headers is deprecated';
+common.expectWarning('DeprecationWarning',warn,'DEP0066');
+
 {
 // tests for _headers get method
 constoutgoingMessage=newOutgoingMessage();