dns: use faster IP address type check on results

PR-URL: #13261 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: mscdex

lib/dns.js

@@ -60,6 +60,31 @@ function errnoException(err, syscall, hostname){
 returnex;
 }
 
+constdigits=[
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 0-15
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 16-31
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 32-47
+1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,0,// 48-63
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 64-79
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 80-95
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,// 96-111
+0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0// 112-127
+];
+functionisIPv4(str){
+if(!digits[str.charCodeAt(0)])returnfalse;
+if(str.length===1)returnfalse;
+if(str.charCodeAt(1)===46/*'.'*/)
+returntrue;
+elseif(!digits[str.charCodeAt(1)])
+returnfalse;
+if(str.length===2)returnfalse;
+if(str.charCodeAt(2)===46/*'.'*/)
+returntrue;
+elseif(!digits[str.charCodeAt(2)])
+returnfalse;
+return(str.length>3&&str.charCodeAt(3)===46/*'.'*/);
+}
+
 
 functiononlookup(err,addresses){
 if(err){
@@ -68,25 +93,26 @@ function onlookup(err, addresses){
 if(this.family){
 this.callback(null,addresses[0],this.family);
 }else{
-this.callback(null,addresses[0],addresses[0].indexOf(':')>=0 ? 6 : 4);
+this.callback(null,addresses[0],isIPv4(addresses[0]) ? 4 : 6);
 }
 }
 
 
 functiononlookupall(err,addresses){
-varresults=[];
 if(err){
 returnthis.callback(errnoException(err,'getaddrinfo',this.hostname));
 }
 
+varfamily=this.family;
 for(vari=0;i<addresses.length;i++){
-results.push({
-address: addresses[i],
-family: this.family||(addresses[i].indexOf(':')>=0 ? 6 : 4)
-});
+constaddr=addresses[i];
+addresses[i]={
+address: addr,
+family: family||(isIPv4(addr) ? 4 : 6)
+};
 }
 
-this.callback(null,results);
+this.callback(null,addresses);
 }