test: simplify test-https-simple.js

It had an unused `Agent` option (no such option exists), and some code that common.must(Not)Call makes redundant. PR-URL: #31584 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: sam-github

test/parallel/test-https-simple.js

@@ -37,16 +37,6 @@ const options ={
 cert: fixtures.readKey('agent1-cert.pem')
 };
 
-consttests=2;
-letsuccessful=0;
-
-consttestSucceeded=()=>{
-successful=successful+1;
-if(successful===tests){
-server.close();
-}
-};
-
 constbody='hello world\n';
 
 constserverCallback=common.mustCall(function(req,res){
@@ -57,61 +47,44 @@ const serverCallback = common.mustCall(function(req, res){
 constserver=https.createServer(options,serverCallback);
 
 server.listen(0,common.mustCall(()=>{
+lettests=0;
+
+functiondone(){
+if(--tests===0)
+server.close();
+}
+
 // Do a request ignoring the unauthorized server certs
 constport=server.address().port;
 
-constnoCertCheckOptions={
+constoptions={
 hostname: '127.0.0.1',
 port: port,
 path: '/',
 method: 'GET',
 rejectUnauthorized: false
 };
-
-noCertCheckOptions.Agent=newhttps.Agent(noCertCheckOptions);
-
-constreq=https.request(noCertCheckOptions,common.mustCall((res)=>{
+tests++;
+constreq=https.request(options,common.mustCall((res)=>{
 letresponseBody='';
 res.on('data',function(d){
 responseBody=responseBody+d;
 });
 
 res.on('end',common.mustCall(()=>{
 assert.strictEqual(responseBody,body);
-testSucceeded();
+done();
 }));
 }));
 req.end();
 
-req.on('error',function(e){
-throwe;
-});
-
-// Do a request that throws error due to the invalid server certs
-constcheckCertOptions={
-hostname: '127.0.0.1',
-port: port,
-path: '/',
-method: 'GET'
-};
-
-constcheckCertReq=https.request(checkCertOptions,function(res){
-res.on('data',function(){
-thrownewError('data should not be received');
-});
-
-res.on('end',function(){
-thrownewError('connection should not be established');
-});
-});
-checkCertReq.end();
+// Do a request that errors due to the invalid server certs
+options.rejectUnauthorized=true;
+tests++;
+constcheckCertReq=https.request(options,common.mustNotCall()).end();
 
 checkCertReq.on('error',common.mustCall((e)=>{
 assert.strictEqual(e.code,'UNABLE_TO_VERIFY_LEAF_SIGNATURE');
-testSucceeded();
+done();
 }));
 }));
-
-process.on('exit',function(){
-assert.strictEqual(successful,tests);
-});