test: reduce test-esm-loader-hooks-inspect-wait flakiness

lpinca · targos · commit 94f242c5ce4d · 2024-10-02T07:58:02.000+02:00
Refs: #51560 PR-URL: #54827 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-esm-loader-hooks-inspect-wait.js b/test/parallel/test-esm-loader-hooks-inspect-wait.js
@@ -10,22 +10,19 @@ const assert = require('assert');
 const fixtures = require('../common/fixtures');
 const{NodeInstance } = require('../common/inspector-helper.js');
 
-async function runIfWaitingForDebugger(session){
- const commands = [
-{'method': 'Runtime.enable' },
-{'method': 'Debugger.enable' },
-{'method': 'Runtime.runIfWaitingForDebugger' },
- ];
-
- await session.send(commands);
-}
-
 async function runTest(){
 const main = fixtures.path('es-module-loaders', 'register-loader.mjs');
 const child = new NodeInstance(['--inspect-wait=0'], '', main);
 
 const session = await child.connectInspectorSession();
- await runIfWaitingForDebugger(session);
+ await session.send({method: 'NodeRuntime.enable' });
+ await session.waitForNotification('NodeRuntime.waitingForDebugger');
+ await session.send([
+{'method': 'Runtime.enable' },
+{'method': 'Debugger.enable' },
+{'method': 'Runtime.runIfWaitingForDebugger' },
+ ]);
+ await session.send({method: 'NodeRuntime.disable' });
 await session.waitForDisconnect();
 assert.strictEqual((await child.expectShutdown()).exitCode, 0);
 }

-Original file line number
+Diff line change
 constfixtures=require('../common/fixtures');
 const{ NodeInstance }=require('../common/inspector-helper.js');
 -asyncfunctionrunIfWaitingForDebugger(session){
 -constcommands=[
 -{'method': 'Runtime.enable'},
 -{'method': 'Debugger.enable'},
 -{'method': 'Runtime.runIfWaitingForDebugger'},
 -];
+-
 -awaitsession.send(commands);
 -}
+-
 asyncfunctionrunTest(){
 constmain=fixtures.path('es-module-loaders','register-loader.mjs');
 constchild=newNodeInstance(['--inspect-wait=0'],'',main);
 constsession=awaitchild.connectInspectorSession();
 -awaitrunIfWaitingForDebugger(session);
 +awaitsession.send({method: 'NodeRuntime.enable'});
 +awaitsession.waitForNotification('NodeRuntime.waitingForDebugger');
 +awaitsession.send([
 +{'method': 'Runtime.enable'},
 +{'method': 'Debugger.enable'},
 +{'method': 'Runtime.runIfWaitingForDebugger'},
 +]);
 +awaitsession.send({method: 'NodeRuntime.disable'});
 awaitsession.waitForDisconnect();
 assert.strictEqual((awaitchild.expectShutdown()).exitCode,0);
+}