stream: pipeline accept Buffer as a valid first argument

change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: #37731 PR-URL: #37739Fixes: #37731 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Linkgoron

lib/internal/streams/utils.js

@@ -6,11 +6,13 @@ const{
 }=primordials;
 
 functionisReadable(obj){
-return!!(obj&&typeofobj.pipe==='function');
+return!!(obj&&typeofobj.pipe==='function'&&
+typeofobj.on==='function');
 }
 
 functionisWritable(obj){
-return!!(obj&&typeofobj.write==='function');
+return!!(obj&&typeofobj.write==='function'&&
+typeofobj.on==='function');
 }
 
 functionisStream(obj){

test/parallel/test-stream-pipeline.js

@@ -1371,3 +1371,19 @@ const net = require('net');
 assert.strictEqual(res,'123');
 }));
 }
+
+{
+constcontent='abc';
+pipeline(Buffer.from(content),PassThrough({objectMode: true}),
+common.mustSucceed(()=>{}));
+
+letres='';
+pipeline(Buffer.from(content),asyncfunction*(previous){
+forawait(constvalofprevious){
+res+=String.fromCharCode(val);
+yieldval;
+}
+},common.mustSucceed(()=>{
+assert.strictEqual(res,content);
+}));
+}