test: fix flaky test-vm-timeout-escape-queuemicrotask

Trott · BridgeAR · commit 957ceaabe631 · 2018-11-14T00:55:54.000+01:00
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: #24296 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status
@@ -10,7 +10,6 @@ prefix known_issues
 
 [$system==linux]
 test-vm-timeout-escape-promise: PASS,FLAKY
-test-vm-timeout-escape-queuemicrotask: PASS,FLAKY
 
 [$system==macos]
 
diff --git a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js
@@ -4,7 +4,7 @@
 // Promises, nextTick, and queueMicrotask allow code to escape the timeout
 // set for runInContext, runInNewContext, and runInThisContext
 
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const vm = require('vm');
 
@@ -32,7 +32,7 @@ assert.throws(() =>{
 queueMicrotask,
 loop
 },
-{timeout: 5 }
+{timeout: common.platformTimeout(5) }
 );
 },{
 code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',

-Original file line number
+Diff line change
 // Promises, nextTick, and queueMicrotask allow code to escape the timeout
 // set for runInContext, runInNewContext, and runInThisContext
 -require('../common');
 +constcommon=require('../common');
 constassert=require('assert');
 constvm=require('vm');
  queueMicrotask,
  loop
 },
 -{timeout: 5}
 +{timeout: common.platformTimeout(5)}
 );
 },{
 code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',