test: don't mask descriptor.enumerable

tomleah · targos · commit 95b2467d5f0d · 2018-08-11T18:10:10.000+02:00
PR-URL: #22172 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
diff --git a/test/common/index.js b/test/common/index.js
@@ -703,8 +703,8 @@ exports.expectsError = function expectsError(fn, settings, exact){
 assert.fail(`Expected one argument, got ${util.inspect(arguments)}`);
 }
 const descriptor = Object.getOwnPropertyDescriptor(error, 'message');
- assert.strictEqual(descriptor.enumerable,
- false, 'The error message should be non-enumerable');
+ // The error message should be non-enumerable
+ assert.strictEqual(descriptor.enumerable, false);
 
 let innerSettings = settings;
 if ('type' in settings){

-Original file line number
+Diff line change
 assert.fail(`Expected one argument, got ${util.inspect(arguments)}`);
+}
 constdescriptor=Object.getOwnPropertyDescriptor(error,'message');
 -assert.strictEqual(descriptor.enumerable,
 -false,'The error message should be non-enumerable');
 +// The error message should be non-enumerable
 +assert.strictEqual(descriptor.enumerable,false);
 letinnerSettings=settings;
 if('type'insettings){