test_runner: better handle async bootstrap errors

The test runner is bootstrapped synchronously, with the exception of importing custom reporters. To better handle asynchronously throw errors, this commit introduces an internal error type that can be checked for from the test runner's uncaughtException handler. After #46707 and this change land, the other throw statement in the uncaughtException handler can be removed. This will allow the test runner to handle errors thrown from outside of tests (which currently prevents the test runner from reporting results). PR-URL: #46720 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: cjihrig

lib/internal/errors.js

@@ -1604,8 +1604,8 @@ E('ERR_TAP_VALIDATION_ERROR', function(errorMsg){
 },Error);
 E('ERR_TEST_FAILURE',function(error,failureType){
 hideInternalStackFrames(this);
-assert(typeoffailureType==='string',
-"The 'failureType' argument must be of type string.");
+assert(typeoffailureType==='string'||typeoffailureType==='symbol',
+"The 'failureType' argument must be of type string or symbol.");
 
 letmsg=error?.message??error;
 

lib/internal/test_runner/harness.js

@@ -16,6 +16,7 @@ const{
 const{ kEmptyObject }=require('internal/util');
 const{ kCancelledByParent, Test, ItTest, Suite }=require('internal/test_runner/test');
 const{
+ kAsyncBootstrapFailure,
  parseCommandLine,
  setupTestReporters,
 }=require('internal/test_runner/utils');
@@ -30,6 +31,13 @@ function createTestTree(options = kEmptyObject){
 
 functioncreateProcessEventHandler(eventName,rootTest){
 return(err)=>{
+if(err?.failureType===kAsyncBootstrapFailure){
+// Something went wrong during the asynchronous portion of bootstrapping
+// the test runner. Since the test runner is not setup properly, we can't
+// do anything but throw the error.
+throwerr.cause;
+}
+
 // Check if this error is coming from a test. If it is, fail the test.
 consttest=testResources.get(executionAsyncId());
 

lib/internal/test_runner/utils.js

@@ -8,6 +8,7 @@ const{
  RegExp,
  RegExpPrototypeExec,
  SafeMap,
+ Symbol,
 }=primordials;
 const{ basename }=require('path');
 const{ createWriteStream }=require('fs');
@@ -24,6 +25,7 @@ const{
 }=require('internal/errors');
 const{ compose }=require('stream');
 
+constkAsyncBootstrapFailure=Symbol('asyncBootstrapFailure');
 constkMultipleCallbackInvocations='multipleCallbackInvocations';
 constkRegExpPattern=/^\/(.*)\/([a-z]*)$/;
 constkSupportedFileExtensions=/\.[cm]?js$/;
@@ -150,11 +152,15 @@ async function getReportersMap(reporters, destinations){
 
 
 asyncfunctionsetupTestReporters(testsStream){
-const{ reporters, destinations }=parseCommandLine();
-constreportersMap=awaitgetReportersMap(reporters,destinations);
-for(leti=0;i<reportersMap.length;i++){
-const{ reporter, destination }=reportersMap[i];
-compose(testsStream,reporter).pipe(destination);
+try{
+const{ reporters, destinations }=parseCommandLine();
+constreportersMap=awaitgetReportersMap(reporters,destinations);
+for(leti=0;i<reportersMap.length;i++){
+const{ reporter, destination }=reportersMap[i];
+compose(testsStream,reporter).pipe(destination);
+}
+}catch(err){
+thrownewERR_TEST_FAILURE(err,kAsyncBootstrapFailure);
 }
 }
 
@@ -220,6 +226,7 @@ module.exports ={
  doesPathMatchFilter,
  isSupportedFileType,
  isTestFailureError,
+ kAsyncBootstrapFailure,
  parseCommandLine,
  setupTestReporters,
 };

test/parallel/test-runner-reporters.js

@@ -116,4 +116,16 @@ describe('node:test reporters',{concurrency: true }, () =>{
 /^package:reporter-esm{"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/,
 );
 });
+
+it('should throw when reporter setup throws asynchronously',async()=>{
+constchild=spawnSync(
+process.execPath,
+['--test','--test-reporter',fixtures.fileURL('empty.js'),'reporters.js'],
+{cwd: fixtures.path('test-runner')}
+);
+assert.strictEqual(child.status,7);
+assert.strictEqual(child.signal,null);
+assert.strictEqual(child.stdout.toString(),'');
+assert.match(child.stderr.toString(),/ERR_INVALID_ARG_TYPE/);
+});
 });