buffer: fix writeUInt16BE range check

mscdex · MylesBorins · commit 9a64ceca390c · 2018-12-26T11:18:50.000-05:00
Fixes: #24205 PR-URL: #24208 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -658,7 +658,7 @@ function writeU_Int16BE(buf, value, offset, min, max){
 }
 
 function writeUInt16BE(value, offset = 0){
- return writeU_Int16BE(this, value, offset, 0, 0xffffffff);
+ return writeU_Int16BE(this, value, offset, 0, 0xffff);
 }
 
 function writeIntLE(value, offset = 0, byteLength){
diff --git a/test/parallel/test-buffer-writeuint.js b/test/parallel/test-buffer-writeuint.js
@@ -84,6 +84,18 @@ const assert = require('assert');
 
 data.writeUInt16BE(value, 0);
 assert.ok(data.equals(new Uint8Array([0xff, 0x80, 0x43, 0x23])));
+
+ value = 0xfffff;
+ ['writeUInt16BE', 'writeUInt16LE'].forEach((fn) =>{
+ assert.throws(
+ () => data[fn](value, 0),
+{
+ code: 'ERR_OUT_OF_RANGE',
+ message: 'The value of "value" is out of range. ' +
+ `It must be >= 0 and <= 65535. Received ${value}`
+ }
+ );
+ });
 }
 
 // Test 32 bit

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ function writeU_Int16BE(buf, value, offset, min, max){`
`658`	`658`	`}`
`659`	`659`
`660`	`660`	`functionwriteUInt16BE(value,offset=0){`
`661`		`-returnwriteU_Int16BE(this,value,offset,0,0xffffffff);`
	`661`	`+returnwriteU_Int16BE(this,value,offset,0,0xffff);`
`662`	`662`	`}`
`663`	`663`
`664`	`664`	`functionwriteIntLE(value,offset=0,byteLength){`
-Original file line number
+Diff line change
 data.writeUInt16BE(value,0);
 assert.ok(data.equals(newUint8Array([0xff,0x80,0x43,0x23])));
++
 +value=0xfffff;
 +['writeUInt16BE','writeUInt16LE'].forEach((fn)=>{
 +assert.throws(
 +()=>data[fn](value,0),
 +{
 +code: 'ERR_OUT_OF_RANGE',
 +message: 'The value of "value" is out of range. '+
 +`It must be >= 0 and <= 65535. Received ${value}`
 +}
 +);
 +});
+}
 // Test 32 bit