test: improves test-tls-client-verify

Swaps var -> const/let assert.equal becomes assert.strictEqual common.mustCall on single-use functions PR-URL: #10051 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: Paul Graham

test/parallel/test-tls-client-verify.js

@@ -1,17 +1,17 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
+constcommon=require('../common');
+constassert=require('assert');
 
 if(!common.hasCrypto){
 common.skip('missing crypto');
 return;
 }
-vartls=require('tls');
+consttls=require('tls');
 
-varfs=require('fs');
+constfs=require('fs');
 
-varhosterr=/Hostname\/IPdoesn'tmatchcertificate'saltnames/g;
-vartestCases=
+consthosterr=/Hostname\/IPdoesn'tmatchcertificate'saltnames/g;
+consttestCases=
 [{ca: ['ca1-cert'],
 key: 'agent2-key',
 cert: 'agent2-cert',
@@ -52,16 +52,16 @@ function loadPEM(n){
 returnfs.readFileSync(filenamePEM(n));
 }
 
-varsuccessfulTests=0;
+letsuccessfulTests=0;
 
 functiontestServers(index,servers,clientOptions,cb){
-varserverOptions=servers[index];
+constserverOptions=servers[index];
 if(!serverOptions){
 cb();
 return;
 }
 
-varok=serverOptions.ok;
+constok=serverOptions.ok;
 
 if(serverOptions.key){
 serverOptions.key=loadPEM(serverOptions.key);
@@ -71,45 +71,45 @@ function testServers(index, servers, clientOptions, cb){
 serverOptions.cert=loadPEM(serverOptions.cert);
 }
 
-varserver=tls.createServer(serverOptions,function(s){
+constserver=tls.createServer(serverOptions,common.mustCall(function(s){
 s.end('hello world\n');
-});
+}));
 
-server.listen(0,function(){
-varb='';
+server.listen(0,common.mustCall(function(){
+letb='';
 
 console.error('connecting...');
 clientOptions.port=this.address().port;
-varclient=tls.connect(clientOptions,function(){
-varauthorized=client.authorized||
-hosterr.test(client.authorizationError);
+constclient=tls.connect(clientOptions,common.mustCall(function(){
+constauthorized=client.authorized||
+hosterr.test(client.authorizationError);
 
 console.error('expected: '+ok+' authed: '+authorized);
 
-assert.equal(ok,authorized);
+assert.strictEqual(ok,authorized);
 server.close();
-});
+}));
 
 client.on('data',function(d){
 b+=d.toString();
 });
 
-client.on('end',function(){
-assert.equal('hello world\n',b);
-});
+client.on('end',common.mustCall(function(){
+assert.strictEqual('hello world\n',b);
+}));
 
-client.on('close',function(){
+client.on('close',common.mustCall(function(){
 testServers(index+1,servers,clientOptions,cb);
-});
-});
+}));
+}));
 }
 
 
 functionrunTest(testIndex){
 vartcase=testCases[testIndex];
 if(!tcase)return;
 
-varclientOptions={
+constclientOptions={
 port: undefined,
 ca: tcase.ca.map(loadPEM),
 key: loadPEM(tcase.key),
@@ -118,10 +118,10 @@ function runTest(testIndex){
 };
 
 
-testServers(0,tcase.servers,clientOptions,function(){
+testServers(0,tcase.servers,clientOptions,common.mustCall(function(){
 successfulTests++;
 runTest(testIndex+1);
-});
+}));
 }