test: slightly refactor test-child-process-execsync

* move `start` time to the point of execution (avoids counting 'throws' tests towards 'timeout' test case) * scope cmd/ret values where possible * use `filter` instead of manual if/return PR-URL: #25227 Refs: #24921 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: lundibundi

test/sequential/test-child-process-execsync.js

@@ -28,10 +28,7 @@ const{execFileSync, execSync, spawnSync } = require('child_process');
 constTIMER=200;
 constSLEEP=2000;
 
-conststart=Date.now();
 constexecOpts={encoding: 'utf8',shell: true};
-leterr;
-letcaught=false;
 
 // Verify that stderr is not accessed when a bad shell is used
 assert.throws(
@@ -43,9 +40,11 @@ assert.throws(
 /spawnSyncbad_shellENOENT/
 );
 
-letcmd,ret;
+letcaught=false;
+letret,err;
+conststart=Date.now();
 try{
-cmd=`"${process.execPath}" -e "setTimeout(function(){}, ${SLEEP});"`;
+constcmd=`"${process.execPath}" -e "setTimeout(function(){}, ${SLEEP});"`;
 ret=execSync(cmd,{timeout: TIMER});
 }catch(e){
 caught=true;
@@ -69,28 +68,32 @@ const msgBuf = Buffer.from(`${msg}\n`);
 
 // console.log ends every line with just '\n', even on Windows.
 
-cmd=`"${process.execPath}" -e "console.log('${msg}');"`;
+constcmd=`"${process.execPath}" -e "console.log('${msg}');"`;
 
-ret=execSync(cmd);
-
-assert.strictEqual(ret.length,msgBuf.length);
-assert.deepStrictEqual(ret,msgBuf);
-
-ret=execSync(cmd,{encoding: 'utf8'});
+{
+constret=execSync(cmd);
+assert.strictEqual(ret.length,msgBuf.length);
+assert.deepStrictEqual(ret,msgBuf);
+}
 
-assert.strictEqual(ret,`${msg}\n`);
+{
+constret=execSync(cmd,{encoding: 'utf8'});
+assert.strictEqual(ret,`${msg}\n`);
+}
 
 constargs=[
 '-e',
 `console.log("${msg}");`
 ];
-ret=execFileSync(process.execPath,args);
-
-assert.deepStrictEqual(ret,msgBuf);
-
-ret=execFileSync(process.execPath,args,{encoding: 'utf8'});
+{
+constret=execFileSync(process.execPath,args);
+assert.deepStrictEqual(ret,msgBuf);
+}
 
-assert.strictEqual(ret,`${msg}\n`);
+{
+constret=execFileSync(process.execPath,args,{encoding: 'utf8'});
+assert.strictEqual(ret,`${msg}\n`);
+}
 
 // Verify that the cwd option works.
 // See https://github.com/nodejs/node-v0.x-archive/issues/7824.
@@ -133,10 +136,11 @@ assert.strictEqual(ret, `${msg}\n`);
 assert.strictEqual(err.message,msg);
 assert.strictEqual(err.status,1);
 assert.strictEqual(typeoferr.pid,'number');
-spawnSyncKeys.forEach((key)=>{
-if(key==='pid')return;
-assert.deepStrictEqual(err[key],spawnSyncResult[key]);
-});
+spawnSyncKeys
+.filter((key)=>key!=='pid')
+.forEach((key)=>{
+assert.deepStrictEqual(err[key],spawnSyncResult[key]);
+});
 returntrue;
 });
 }