Skip to content

Commit 9fa7146

Browse files
eiskalteschattenMylesBorins
authored andcommitted
test: fix order of arguments in assert.strictEqual
PR-URL: #24145 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent a1d7ed7 commit 9fa7146

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

‎test/parallel/test-buffer-indexof.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -505,20 +505,20 @@ assert.strictEqual(buf_bc.lastIndexOf(Buffer.from('你好'), 7), -1);
505505

506506
// Test lastIndexOf on a longer buffer:
507507
constbufferString=Buffer.from('a man a plan a canal panama');
508-
assert.strictEqual(15,bufferString.lastIndexOf('canal'));
509-
assert.strictEqual(21,bufferString.lastIndexOf('panama'));
510-
assert.strictEqual(0,bufferString.lastIndexOf('a man a plan a canal panama'));
508+
assert.strictEqual(bufferString.lastIndexOf('canal'),15);
509+
assert.strictEqual(bufferString.lastIndexOf('panama'),21);
510+
assert.strictEqual(bufferString.lastIndexOf('a man a plan a canal panama'),0);
511511
assert.strictEqual(-1,bufferString.lastIndexOf('a man a plan a canal mexico'));
512512
assert.strictEqual(-1,bufferString
513513
.lastIndexOf('a man a plan a canal mexico city'));
514514
assert.strictEqual(-1,bufferString.lastIndexOf(Buffer.from('a'.repeat(1000))));
515-
assert.strictEqual(0,bufferString.lastIndexOf('a man a plan',4));
516-
assert.strictEqual(13,bufferString.lastIndexOf('a '));
517-
assert.strictEqual(13,bufferString.lastIndexOf('a ',13));
518-
assert.strictEqual(6,bufferString.lastIndexOf('a ',12));
519-
assert.strictEqual(0,bufferString.lastIndexOf('a ',5));
520-
assert.strictEqual(13,bufferString.lastIndexOf('a ',-1));
521-
assert.strictEqual(0,bufferString.lastIndexOf('a ',-27));
515+
assert.strictEqual(bufferString.lastIndexOf('a man a plan',4),0);
516+
assert.strictEqual(bufferString.lastIndexOf('a '),13);
517+
assert.strictEqual(bufferString.lastIndexOf('a ',13),13);
518+
assert.strictEqual(bufferString.lastIndexOf('a ',12),6);
519+
assert.strictEqual(bufferString.lastIndexOf('a ',5),0);
520+
assert.strictEqual(bufferString.lastIndexOf('a ',-1),13);
521+
assert.strictEqual(bufferString.lastIndexOf('a ',-27),0);
522522
assert.strictEqual(-1,bufferString.lastIndexOf('a ',-28));
523523

524524
// Test lastIndexOf for the case that the first character can be found,
@@ -534,18 +534,18 @@ assert.strictEqual(-1, Buffer.from('bc').lastIndexOf(Buffer.from('ab')));
534534
assert.strictEqual(-1,Buffer.from('bc','ucs2').lastIndexOf('ab','ucs2'));
535535
assert.strictEqual(-1,Buffer.from('bc','ucs2').lastIndexOf(abInUCS2));
536536

537-
assert.strictEqual(0,Buffer.from('abc').lastIndexOf('ab'));
538-
assert.strictEqual(0,Buffer.from('abc').lastIndexOf('ab',1));
539-
assert.strictEqual(0,Buffer.from('abc').lastIndexOf('ab',2));
540-
assert.strictEqual(0,Buffer.from('abc').lastIndexOf('ab',3));
537+
assert.strictEqual(Buffer.from('abc').lastIndexOf('ab'),0);
538+
assert.strictEqual(Buffer.from('abc').lastIndexOf('ab',1),0);
539+
assert.strictEqual(Buffer.from('abc').lastIndexOf('ab',2),0);
540+
assert.strictEqual(Buffer.from('abc').lastIndexOf('ab',3),0);
541541

542542
// The above tests test the LINEAR and SINGLE-CHAR strategies.
543543
// Now, we test the BOYER-MOORE-HORSPOOL strategy.
544544
// Test lastIndexOf on a long buffer w multiple matches:
545545
pattern='JABACABADABACABA';
546-
assert.strictEqual(1535,longBufferString.lastIndexOf(pattern));
547-
assert.strictEqual(1535,longBufferString.lastIndexOf(pattern,1535));
548-
assert.strictEqual(511,longBufferString.lastIndexOf(pattern,1534));
546+
assert.strictEqual(longBufferString.lastIndexOf(pattern),1535);
547+
assert.strictEqual(longBufferString.lastIndexOf(pattern,1535),1535);
548+
assert.strictEqual(longBufferString.lastIndexOf(pattern,1534),511);
549549

550550
// Finally, give it a really long input to trigger fallback from BMH to
551551
// regular BOYER-MOORE (which has better worst-case complexity).
@@ -567,19 +567,19 @@ for (let i = 0; i < 1000000; i++){
567567
parts.push((countBits(i)%2===0) ? 'yolo' : 'swag');
568568
}
569569
constreallyLong=Buffer.from(parts.join(' '));
570-
assert.strictEqual('yolo swag swag yolo',reallyLong.slice(0,19).toString());
570+
assert.strictEqual(reallyLong.slice(0,19).toString(),'yolo swag swag yolo');
571571

572572
// Expensive reverse searches. Stress test lastIndexOf:
573573
pattern=reallyLong.slice(0,100000);// First 1/50th of the pattern.
574-
assert.strictEqual(4751360,reallyLong.lastIndexOf(pattern));
575-
assert.strictEqual(3932160,reallyLong.lastIndexOf(pattern,4000000));
576-
assert.strictEqual(2949120,reallyLong.lastIndexOf(pattern,3000000));
574+
assert.strictEqual(reallyLong.lastIndexOf(pattern),4751360);
575+
assert.strictEqual(reallyLong.lastIndexOf(pattern,4000000),3932160);
576+
assert.strictEqual(reallyLong.lastIndexOf(pattern,3000000),2949120);
577577
pattern=reallyLong.slice(100000,200000);// Second 1/50th.
578-
assert.strictEqual(4728480,reallyLong.lastIndexOf(pattern));
578+
assert.strictEqual(reallyLong.lastIndexOf(pattern),4728480);
579579
pattern=reallyLong.slice(0,1000000);// First 1/5th.
580-
assert.strictEqual(3932160,reallyLong.lastIndexOf(pattern));
580+
assert.strictEqual(reallyLong.lastIndexOf(pattern),3932160);
581581
pattern=reallyLong.slice(0,2000000);// first 2/5ths.
582-
assert.strictEqual(0,reallyLong.lastIndexOf(pattern));
582+
assert.strictEqual(reallyLong.lastIndexOf(pattern),0);
583583

584584
// test truncation of Number arguments to uint8
585585
{

0 commit comments

Comments
(0)