test: fix test-vm-memleak for high baseline platforms

Trott · jasnell · commit a0492ba3912e · 2021-04-06T09:23:31.000-07:00
test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb. PR-URL: #38062 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/pummel/test-vm-memleak.js b/test/pummel/test-vm-memleak.js
@@ -26,6 +26,8 @@ require('../common');
 const assert = require('assert');
 const vm = require('vm');
 
+const baselineRss = process.memoryUsage.rss();
+
 const start = Date.now();
 
 const interval = setInterval(function(){
@@ -36,8 +38,8 @@ const interval = setInterval(function(){
 
 global.gc();
 const rss = process.memoryUsage.rss();
- assert.ok(rss < 64 * 1024 * 1024,
- `memory usage: ${rss} (${Math.round(rss / (1024 * 1024))} MB)`);
+ assert.ok(rss < baselineRss + 32 * 1024 * 1024,
+ `memory usage: ${rss} baseline: ${baselineRss}`);
 
 // Stop after 5 seconds.
 if (Date.now() - start > 5 * 1000){

-Original file line number
+Diff line change
 constassert=require('assert');
 constvm=require('vm');
 +constbaselineRss=process.memoryUsage.rss();
++
 conststart=Date.now();
 constinterval=setInterval(function(){
 global.gc();
 constrss=process.memoryUsage.rss();
 -assert.ok(rss<64*1024*1024,
 -`memory usage: ${rss}(${Math.round(rss/(1024*1024))} MB)`);
 +assert.ok(rss<baselineRss+32*1024*1024,
 +`memory usage: ${rss}baseline: ${baselineRss}`);
 // Stop after 5 seconds.
 if(Date.now()-start>5*1000){