test: print instruction for creating missing snapshot in assertSnapshot

rluvaton · targos · commit a2ca1a605ff8 · 2023-11-27T11:57:28.000+01:00
PR-URL: #48914 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/common/assertSnapshot.js b/test/common/assertSnapshot.js
@@ -42,7 +42,17 @@ async function assertSnapshot(actual, filename = process.argv[1]){
 if (process.env.NODE_REGENERATE_SNAPSHOTS){
 await fs.writeFile(snapshot, actual);
 } else{
- const expected = await fs.readFile(snapshot, 'utf8');
+ let expected;
+ try{
+ expected = await fs.readFile(snapshot, 'utf8');
+ } catch (e){
+ if (e.code === 'ENOENT'){
+ console.log(
+ 'Snapshot file does not exist. You can create a new one by running the test with NODE_REGENERATE_SNAPSHOTS=1',
+ );
+ }
+ throw e;
+ }
 assert.strictEqual(actual, replaceWindowsLineEndings(expected));
 }
 }

-Original file line number
+Diff line change
 if(process.env.NODE_REGENERATE_SNAPSHOTS){
 awaitfs.writeFile(snapshot,actual);
 }else{
 -constexpected=awaitfs.readFile(snapshot,'utf8');
 +letexpected;
 +try{
 +expected=awaitfs.readFile(snapshot,'utf8');
 +}catch(e){
 +if(e.code==='ENOENT'){
 +console.log(
 +'Snapshot file does not exist. You can create a new one by running the test with NODE_REGENERATE_SNAPSHOTS=1',
 +);
 +}
 +throwe;
 +}
 assert.strictEqual(actual,replaceWindowsLineEndings(expected));
+}
+}