http: do not override user-provided options object

PR-URL: #33633 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: KuthorX

lib/_http_client.js

@@ -186,9 +186,11 @@ function ClientRequest(input, options, cb){
 constdefaultPort=options.defaultPort||
 (this.agent&&this.agent.defaultPort);
 
-constport=options.port=options.port||defaultPort||80;
-consthost=options.host=validateHost(options.hostname,'hostname')||
-validateHost(options.host,'host')||'localhost';
+constoptsWithoutSignal={__proto__: null, ...options};
+
+constport=optsWithoutSignal.port=options.port||defaultPort||80;
+consthost=optsWithoutSignal.host=validateHost(options.hostname,'hostname')||
+validateHost(options.host,'host')||'localhost';
 
 constsetHost=(options.setHost===undefined||Boolean(options.setHost));
 
@@ -200,6 +202,7 @@ function ClientRequest(input, options, cb){
 constsignal=options.signal;
 if(signal){
 addAbortSignal(signal,this);
+deleteoptsWithoutSignal.signal;
 }
 letmethod=options.method;
 constmethodIsString=(typeofmethod==='string');
@@ -326,12 +329,6 @@ function ClientRequest(input, options, cb){
 
 this[kUniqueHeaders]=parseUniqueHeadersOption(options.uniqueHeaders);
 
-letoptsWithoutSignal=options;
-if(optsWithoutSignal.signal){
-optsWithoutSignal=ObjectAssign({},options);
-deleteoptsWithoutSignal.signal;
-}
-
 // initiate connection
 if(this.agent){
 this.agent.addRequest(this,optsWithoutSignal);

test/parallel/test-http-client-input-function.js

@@ -0,0 +1,29 @@
+'use strict';
+
+constcommon=require('../common');
+consthttp=require('http');
+constassert=require('assert');
+
+{
+constserver=http.createServer(common.mustCall((req,res)=>{
+res.writeHead(200);
+res.end('hello world');
+})).listen(0,'127.0.0.1');
+
+server.on('listening',common.mustCall(()=>{
+constreq=newhttp.ClientRequest(server.address(),common.mustCall((response)=>{
+letbody='';
+response.setEncoding('utf8');
+response.on('data',(chunk)=>{
+body+=chunk;
+});
+
+response.on('end',common.mustCall(()=>{
+assert.strictEqual(body,'hello world');
+server.close();
+}));
+}));
+
+req.end();
+}));
+}

test/parallel/test-http-client-insecure-http-parser-error.js

@@ -0,0 +1,14 @@
+'use strict';
+
+require('../common');
+constassert=require('assert');
+constClientRequest=require('http').ClientRequest;
+
+{
+assert.throws(()=>{
+newClientRequest({insecureHTTPParser: 'wrongValue'});
+},{
+code: 'ERR_INVALID_ARG_TYPE',
+message: /insecureHTTPParser/
+},'http request should throw when passing invalid insecureHTTPParser');
+}