http2: refactor to use primordials instead of <string>.indexOf

rchougule · danielleadams · commit a38ad0709cf7 · 2021-01-12T07:10:51.000-05:00
PR-URL: #36679 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -11,6 +11,7 @@ const{
 ObjectPrototypeHasOwnProperty,
 ReflectApply,
 ReflectGetPrototypeOf,
+ StringPrototypeIncludes,
 StringPrototypeToLowerCase,
 StringPrototypeTrim,
 Symbol,
@@ -81,7 +82,9 @@ let statusConnectionHeaderWarned = false;
 // close as possible to the current require('http') API
 
 const assertValidHeader = hideStackFrames((name, value) =>{
- if (name === '' || typeof name !== 'string' || name.indexOf(' ') >= 0){
+ if (name === '' ||
+ typeof name !== 'string' ||
+ StringPrototypeIncludes(name, ' ')){
 throw new ERR_INVALID_HTTP_TOKEN('Header name', name);
 }
 if (isPseudoHeader(name)){

-Original file line number
+Diff line change
  ObjectPrototypeHasOwnProperty,
  ReflectApply,
  ReflectGetPrototypeOf,
 + StringPrototypeIncludes,
  StringPrototypeToLowerCase,
  StringPrototypeTrim,
  Symbol,
 // close as possible to the current require('http') API
 constassertValidHeader=hideStackFrames((name,value)=>{
 -if(name===''||typeofname!=='string'||name.indexOf(' ')>=0){
 +if(name===''||
 +typeofname!=='string'||
 +StringPrototypeIncludes(name,' ')){
 thrownewERR_INVALID_HTTP_TOKEN('Header name',name);
+}
 if(isPseudoHeader(name)){