src: fix uv_err_name memory leak

theanarkh · juanarbol · commit a3dc7e18ed6d · 2022-10-11T14:45:20.000-05:00
PR-URL: #44421 Refs: #44401 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/src/uv.cc b/src/uv.cc
@@ -73,7 +73,8 @@ void ErrName(const FunctionCallbackInfo<Value>& args){
 int err;
 if (!args[0]->Int32Value(env->context()).To(&err)) return;
 CHECK_LT(err, 0);
- const char* name = uv_err_name(err);
+ char name[50];
+ uv_err_name_r(err, name, sizeof(name));
 args.GetReturnValue().Set(OneByteString(env->isolate(), name));
 }
 
diff --git a/test/parallel/test-uv-errno.js b/test/parallel/test-uv-errno.js
@@ -12,6 +12,8 @@ const{internalBinding } = require('internal/test/binding');
 const uv = internalBinding('uv');
 const keys = Object.keys(uv);
 
+assert.strictEqual(uv.errname(-111111), 'Unknown system error -111111');
+
 keys.forEach((key) =>{
 if (!key.startsWith('UV_'))
 return;

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,8 @@ void ErrName(const FunctionCallbackInfo<Value>& args){`
`73`	`73`	`int err;`
`74`	`74`	`if (!args[0]->Int32Value(env->context()).To(&err)) return;`
`75`	`75`	`CHECK_LT(err, 0);`
`76`		`-constchar* name = uv_err_name(err);`
	`76`	`+char name[50];`
	`77`	`+uv_err_name_r(err, name, sizeof(name));`
`77`	`78`	`args.GetReturnValue().Set(OneByteString(env->isolate(), name));`
`78`	`79`	`}`
`79`	`80`
-Original file line number
+Diff line change
 constuv=internalBinding('uv');
 constkeys=Object.keys(uv);
 +assert.strictEqual(uv.errname(-111111),'Unknown system error -111111');
++
 keys.forEach((key)=>{
 if(!key.startsWith('UV_'))
 return;