test: fix parsing test flags

daeyeon · targos · commit a41cfd183f7b · 2023-05-30T11:36:12.000+02:00
This removes replacing `_` with `-` in the flags defined. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #48012 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/common/index.js b/test/common/index.js
@@ -82,7 +82,6 @@ function parseTestFlags(filename = process.argv[1]){
 }
 return source
 .substring(flagStart, flagEnd)
- .replace(/_/g, '-')
 .split(/\s+/)
 .filter(Boolean);
 }
@@ -98,9 +97,8 @@ if (process.argv.length === 2 &&
 require('cluster').isPrimary &&
 fs.existsSync(process.argv[1])){
 const flags = parseTestFlags();
- const args = process.execArgv.map((arg) => arg.replace(/_/g, '-'));
 for (const flag of flags){
- if (!args.includes(flag) &&
+ if (!process.execArgv.includes(flag) &&
 // If the binary is build without `intl` the inspect option is
 // invalid. The test itself should handle this case.
 (process.features.inspector || !flag.startsWith('--inspect'))){

-Original file line number
+Diff line change
+}
 returnsource
 .substring(flagStart,flagEnd)
 -.replace(/_/g,'-')
 .split(/\s+/)
 .filter(Boolean);
+}
 require('cluster').isPrimary&&
 fs.existsSync(process.argv[1])){
 constflags=parseTestFlags();
 -constargs=process.execArgv.map((arg)=>arg.replace(/_/g,'-'));
 for(constflagofflags){
 -if(!args.includes(flag)&&
 +if(!process.execArgv.includes(flag)&&
 // If the binary is build without `intl` the inspect option is
 // invalid. The test itself should handle this case.
 (process.features.inspector||!flag.startsWith('--inspect'))){