http: include provided status code in range error

ServerResponse#writeHead() coerces the user provided status code to a number and then performs a range check. If the check fails, a range error is thrown. The coerced status code is included in the error message. This commit uses the user provided status code instead. PR-URL: #11221 Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

lib/_http_server.js

@@ -161,9 +161,11 @@ ServerResponse.prototype._implicitHeader = function _implicitHeader(){
 
 ServerResponse.prototype.writeHead=writeHead;
 functionwriteHead(statusCode,reason,obj){
+varoriginalStatusCode=statusCode;
+
 statusCode|=0;
 if(statusCode<100||statusCode>999)
-thrownewRangeError(`Invalid status code: ${statusCode}`);
+thrownewRangeError(`Invalid status code: ${originalStatusCode}`);
 
 if(typeofreason==='string'){
 // writeHead(statusCode, reasonPhrase[, headers])

test/parallel/test-http-response-statuscode.js

@@ -20,17 +20,17 @@ const server = http.Server(common.mustCall(function(req, res){
 case1:
 assert.throws(common.mustCall(()=>{
 res.writeHead(Infinity);
-}),createErrorMessage(0));
+}),createErrorMessage(Infinity));
 break;
 case2:
 assert.throws(common.mustCall(()=>{
 res.writeHead(NaN);
-}),createErrorMessage(0));
+}),createErrorMessage(NaN));
 break;
 case3:
 assert.throws(common.mustCall(()=>{
 res.writeHead({});
-}),createErrorMessage(0));
+}),createErrorMessage('\\[object Object\\]'));
 break;
 case4:
 assert.throws(common.mustCall(()=>{
@@ -45,37 +45,37 @@ const server = http.Server(common.mustCall(function(req, res){
 case6:
 assert.throws(common.mustCall(()=>{
 res.writeHead('1000');
-}),createErrorMessage(1000));
+}),createErrorMessage('1000'));
 break;
 case7:
 assert.throws(common.mustCall(()=>{
 res.writeHead(null);
-}),createErrorMessage(0));
+}),createErrorMessage(null));
 break;
 case8:
 assert.throws(common.mustCall(()=>{
 res.writeHead(true);
-}),createErrorMessage(1));
+}),createErrorMessage(true));
 break;
 case9:
 assert.throws(common.mustCall(()=>{
 res.writeHead([]);
-}),createErrorMessage(0));
+}),createErrorMessage([]));
 break;
 case10:
 assert.throws(common.mustCall(()=>{
 res.writeHead('this is not valid');
-}),createErrorMessage(0));
+}),createErrorMessage('this is not valid'));
 break;
 case11:
 assert.throws(common.mustCall(()=>{
 res.writeHead('404 this is not valid either');
-}),createErrorMessage(0));
+}),createErrorMessage('404 this is not valid either'));
 break;
 case12:
 assert.throws(common.mustCall(()=>{
 res.writeHead();
-}),createErrorMessage(0));
+}),createErrorMessage(undefined));
 this.close();
 break;
 default: