src: reduce unnecessary serialization of CLI options in C++

In this patch we split the serialization routine into two different routines: `getCLIOptionsValues()` for only serializing the key-value pairs and `getCLIOptionsInfo()` for getting additional information such as help text etc. The former is used a lot more frequently than the latter, which is only used for generating `--help` and building `process.allowedNodeEnvironmentFlags`. `getCLIOptionsValues()` also adds `--no-` entries for boolean options so there is no need to special case in the JS land. This patch also refactors the option serialization routines to use v8::Object constructor that takes key-value pairs in one go to avoid calling Map::Set or Object::Set repeatedly which can go up to a patched prototype. PR-URL: #52451 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: joyeecheung

lib/internal/main/print_help.js

@@ -24,6 +24,8 @@ const{
  markBootstrapComplete,
 }=require('internal/process/pre_execution');
 
+const{ getCLIOptionsInfo, getOptionValue }=require('internal/options');
+
 consttypeLookup=[];
 for(constkeyofObjectKeys(types))
 typeLookup[types[key]]=key;
@@ -134,9 +136,10 @@ function format(
 );
 
 for(const{
-0: name,1: { helpText, type,value,defaultIsTrue },
+0: name,1: { helpText, type, defaultIsTrue },
 }ofsortedOptions){
 if(!helpText)continue;
+constvalue=getOptionValue(name);
 
 letdisplayName=name;
 
@@ -198,7 +201,7 @@ function format(
 }
 
 functionprint(stream){
-const{ options, aliases }=require('internal/options');
+const{ options, aliases }=getCLIOptionsInfo();
 
 // Use 75 % of the available width, and at least 70 characters.
 constwidth=MathMax(70,(stream.columns||0)*0.75);

lib/internal/options.js

@@ -1,36 +1,33 @@
 'use strict';
 
 const{
- getCLIOptions,
+ getCLIOptionsValues,
+ getCLIOptionsInfo,
 getEmbedderOptions: getEmbedderOptionsFromBinding,
 }=internalBinding('options');
 
-const{
- StringPrototypeSlice,
-}=primordials;
-
 letwarnOnAllowUnauthorized=true;
 
-letoptionsMap;
-letaliasesMap;
+letoptionsDict;
+letcliInfo;
 letembedderOptions;
 
-// getCLIOptions() would serialize the option values from C++ land.
+// getCLIOptionsValues() would serialize the option values from C++ land.
 // It would error if the values are queried before bootstrap is
 // complete so that we don't accidentally include runtime-dependent
 // states into a runtime-independent snapshot.
 functiongetCLIOptionsFromBinding(){
-if(!optionsMap){
-({options: optionsMap}=getCLIOptions());
+if(!optionsDict){
+optionsDict=getCLIOptionsValues();
 }
-returnoptionsMap;
+returnoptionsDict;
 }
 
-functiongetAliasesFromBinding(){
-if(!aliasesMap){
-({aliases: aliasesMap}=getCLIOptions());
+functiongetCLIOptionsInfoFromBinding(){
+if(!cliInfo){
+cliInfo=getCLIOptionsInfo();
 }
-returnaliasesMap;
+returncliInfo;
 }
 
 functiongetEmbedderOptions(){
@@ -41,24 +38,12 @@ function getEmbedderOptions(){
 }
 
 functionrefreshOptions(){
-optionsMap=undefined;
-aliasesMap=undefined;
+optionsDict=undefined;
 }
 
 functiongetOptionValue(optionName){
-constoptions=getCLIOptionsFromBinding();
-if(
-optionName.length>5&&
-optionName[0]==='-'&&
-optionName[1]==='-'&&
-optionName[2]==='n'&&
-optionName[3]==='o'&&
-optionName[4]==='-'
-){
-constoption=options.get('--'+StringPrototypeSlice(optionName,5));
-returnoption&&!option.value;
-}
-returnoptions.get(optionName)?.value;
+constoptionsDict=getCLIOptionsFromBinding();
+returnoptionsDict[optionName];
 }
 
 functiongetAllowUnauthorized(){
@@ -76,12 +61,7 @@ function getAllowUnauthorized(){
 }
 
 module.exports={
-getoptions(){
-returngetCLIOptionsFromBinding();
-},
-getaliases(){
-returngetAliasesFromBinding();
-},
+getCLIOptionsInfo: getCLIOptionsInfoFromBinding,
  getOptionValue,
  getAllowUnauthorized,
  getEmbedderOptions,

lib/internal/process/per_thread.js

@@ -287,7 +287,8 @@ function buildAllowedFlags(){
 envSettings: { kAllowedInEnvvar },
 types: { kBoolean },
 }=internalBinding('options');
-const{ options, aliases }=require('internal/options');
+const{ getCLIOptionsInfo }=require('internal/options');
+const{ options, aliases }=getCLIOptionsInfo();
 
 constallowedNodeEnvironmentFlags=[];
 for(const{0: name,1: info}ofoptions){