http: remove pointless use of arguments

cjihrig · cjihrig · commit a73ab9de0dfd · 2017-01-10T14:03:45.000-05:00
PR-URL: #10664 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -382,8 +382,8 @@ OutgoingMessage.prototype.setHeader = function setHeader(name, value){
 
 
 OutgoingMessage.prototype.getHeader = function getHeader(name){
- if (arguments.length < 1){
- throw new Error('"name" argument is required for getHeader(name)');
+ if (typeof name !== 'string'){
+ throw new TypeError('"name" argument must be a string');
 }
 
 if (!this._headers) return;
@@ -393,8 +393,8 @@ OutgoingMessage.prototype.getHeader = function getHeader(name){
 
 
 OutgoingMessage.prototype.removeHeader = function removeHeader(name){
- if (arguments.length < 1){
- throw new Error('"name" argument is required for removeHeader(name)');
+ if (typeof name !== 'string'){
+ throw new TypeError('"name" argument must be a string');
 }
 
 if (this._header){

-Original file line number
+Diff line change
 OutgoingMessage.prototype.getHeader=functiongetHeader(name){
 -if(arguments.length<1){
 -thrownewError('"name" argument is required for getHeader(name)');
 +if(typeofname!=='string'){
 +thrownewTypeError('"name" argument must be a string');
+}
 if(!this._headers)return;
 OutgoingMessage.prototype.removeHeader=functionremoveHeader(name){
 -if(arguments.length<1){
 -thrownewError('"name" argument is required for removeHeader(name)');
 +if(typeofname!=='string'){
 +thrownewTypeError('"name" argument must be a string');
+}
 if(this._header){