test: refactor test-tls-env-extra-ca

* Use `common.mustCall()` to guarantee callback invocations * Order modules according to test writing guide PR-URL: #13886 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Author: Trott

test/parallel/test-tls-env-extra-ca.js

@@ -9,18 +9,19 @@ if (!common.hasCrypto){
 }
 
 constassert=require('assert');
+constfs=require('fs');
 consttls=require('tls');
+
 constfork=require('child_process').fork;
-constfs=require('fs');
 
 if(process.env.CHILD){
 constcopts={
 port: process.env.PORT,
-checkServerIdentity: common.noop,
+checkServerIdentity: common.mustCall(),
 };
-constclient=tls.connect(copts,function(){
+constclient=tls.connect(copts,common.mustCall(function(){
 client.end('hi');
-});
+}));
 return;
 }
 
@@ -29,10 +30,10 @@ const options ={
 cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`),
 };
 
-constserver=tls.createServer(options,function(s){
+constserver=tls.createServer(options,common.mustCall(function(s){
 s.end('bye');
 server.close();
-}).listen(0,common.mustCall(function(){
+})).listen(0,common.mustCall(function(){
 constenv={
 CHILD: 'yes',
 PORT: this.address().port,