assert: remove unneeded arguments special handling

Remove special handling when asserting on a pair of arguments objects. The code being removed will only run if both `expected` and `actual` are arguments objects. Given that situation, the subsequent code for handling everything else works just fine. Tests added to confirm expected behavior. This came about while trying to improve test coverage. The segment of code removed had no test coverage. I was unable to write a test that would both exercise the code and fail if the code was removed. Further examination indicated that this was because the special handling was not needed. PR-URL: #7413 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Trott

lib/assert.js

@@ -28,7 +28,6 @@
 constcompare=process.binding('buffer').compare;
 constutil=require('util');
 constBuffer=require('buffer').Buffer;
-constpSlice=Array.prototype.slice;
 constpToString=(obj)=>Object.prototype.toString.call(obj);
 
 // 1. The assert module provides functions that throw
@@ -223,11 +222,6 @@ function objEquiv(a, b, strict, actualVisitedObjects){
 constbIsArgs=isArguments(b);
 if((aIsArgs&&!bIsArgs)||(!aIsArgs&&bIsArgs))
 returnfalse;
-if(aIsArgs){
-a=pSlice.call(a);
-b=pSlice.call(b);
-return_deepEqual(a,b,strict);
-}
 constka=Object.keys(a);
 constkb=Object.keys(b);
 varkey,i;

test/parallel/test-assert.js

@@ -58,7 +58,7 @@ assert.throws(makeBlock(a.strictEqual, null, undefined),
 assert.doesNotThrow(makeBlock(a.notStrictEqual,2,'2'),
 'notStrictEqual(2, \'2\')');
 
-// deepEquals joy!
+// deepEqual joy!
 // 7.2
 assert.doesNotThrow(makeBlock(a.deepEqual,newDate(2000,3,14),
 newDate(2000,3,14)),
@@ -408,6 +408,20 @@ var args = (function(){return arguments})();
 a.throws(makeBlock(a.deepEqual,[],args));
 a.throws(makeBlock(a.deepEqual,args,[]));
 
+// more checking that arguments objects are handled correctly
+{
+constreturnArguments=function(){returnarguments;};
+
+constsomeArgs=returnArguments('a');
+constsameArgs=returnArguments('a');
+constdiffArgs=returnArguments('b');
+
+a.throws(makeBlock(a.deepEqual,someArgs,['a']));
+a.throws(makeBlock(a.deepEqual,['a'],someArgs));
+a.throws(makeBlock(a.deepEqual,someArgs,{'0': 'a'}));
+a.throws(makeBlock(a.deepEqual,someArgs,diffArgs));
+a.doesNotThrow(makeBlock(a.deepEqual,someArgs,sameArgs));
+}
 
 varcircular={y: 1};
 circular.x=circular;