net: return this from getConnections()

PR-URL: #13553 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: sam-github

doc/api/net.md

@@ -162,6 +162,8 @@ connections use asynchronous `server.getConnections` instead.
 added: v0.9.7
 -->
 
+* Returns{net.Server}
+
 Asynchronously get the number of concurrent connections on the server. Works
 when sockets were sent to forks.
 

lib/net.js

@@ -1558,7 +1558,8 @@ Server.prototype.getConnections = function(cb){
 }
 
 if(!this._usingSlaves){
-returnend(null,this._connections);
+end(null,this._connections);
+returnthis;
 }
 
 // Poll slaves
@@ -1578,6 +1579,8 @@ Server.prototype.getConnections = function(cb){
 for(varn=0;n<this._slaves.length;n++){
 this._slaves[n].getConnections(oncount);
 }
+
+returnthis;
 };
 
 

test/parallel/test-net-pingpong.js

@@ -37,10 +37,13 @@ function pingPongTest(port, host){
 
 functiononSocket(socket){
 assert.strictEqual(socket.server,server);
-server.getConnections(common.mustCall(function(err,connections){
-assert.ifError(err);
-assert.strictEqual(connections,1);
-}));
+assert.strictEqual(
+server,
+server.getConnections(common.mustCall(function(err,connections){
+assert.ifError(err);
+assert.strictEqual(connections,1);
+}))
+);
 
 socket.setNoDelay();
 socket.timeout=0;