lib: enforce use of Promise from primordials

PR-URL: #30936 Refs: #30697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Author: targos

lib/.eslintrc.yaml

@@ -23,6 +23,8 @@ rules:
 message: "Use `const{Number } = primordials;` instead of the global."
  - name: Object
 message: "Use `const{Object } = primordials;` instead of the global."
+ - name: Promise
+message: "Use `const{Promise } = primordials;` instead of the global."
  - name: Reflect
 message: "Use `const{Reflect } = primordials;` instead of the global."
  - name: Symbol

lib/child_process.js

@@ -27,6 +27,7 @@ const{
  ObjectAssign,
  ObjectDefineProperty,
  ObjectPrototypeHasOwnProperty,
+ Promise,
 }=primordials;
 
 const{

lib/events.js

@@ -29,6 +29,7 @@ const{
  ObjectDefineProperty,
  ObjectGetPrototypeOf,
  ObjectKeys,
+ Promise,
  ReflectApply,
  ReflectOwnKeys,
 }=primordials;

lib/fs.js

@@ -30,6 +30,7 @@ const{
  ObjectCreate,
  ObjectDefineProperties,
  ObjectDefineProperty,
+ Promise,
 }=primordials;
 
 const{fs: constants}=internalBinding('constants');

lib/internal/dns/promises.js

@@ -3,6 +3,7 @@
 const{
  ObjectCreate,
  ObjectDefineProperty,
+ Promise,
 }=primordials;
 
 const{

lib/internal/fs/rimraf.js

@@ -5,6 +5,11 @@
 // - Bring your own custom fs module is not currently supported.
 // - Some basic code cleanup.
 'use strict';
+
+const{
+ Promise,
+}=primordials;
+
 const{
  chmod,
  chmodSync,

lib/internal/http2/core.js

@@ -10,6 +10,7 @@ const{
  ObjectCreate,
  ObjectDefineProperty,
  ObjectPrototypeHasOwnProperty,
+ Promise,
  ReflectGetPrototypeOf,
  Symbol,
 }=primordials;

lib/internal/modules/esm/module_job.js

@@ -2,6 +2,7 @@
 
 const{
  ObjectSetPrototypeOf,
+ PromiseAll,
  SafeSet,
  SafePromise,
 }=primordials;
@@ -79,7 +80,7 @@ class ModuleJob{
 }
 jobsInGraph.add(moduleJob);
 constdependencyJobs=awaitmoduleJob.linked;
-returnPromise.all(dependencyJobs.map(addJobsToDependencyGraph));
+returnPromiseAll(dependencyJobs.map(addJobsToDependencyGraph));
 };
 awaitaddJobsToDependencyGraph(this);
 try{

lib/internal/per_context/primordials.js

@@ -47,6 +47,22 @@ function copyPropsRenamed(src, dest, prefix){
 }
 }
 
+functioncopyPropsRenamedBound(src,dest,prefix){
+for(constkeyofReflect.ownKeys(src)){
+if(typeofkey==='string'){
+constdesc=Reflect.getOwnPropertyDescriptor(src,key);
+if(typeofdesc.value==='function'){
+desc.value=desc.value.bind(src);
+}
+Reflect.defineProperty(
+dest,
+`${prefix}${key[0].toUpperCase()}${key.slice(1)}`,
+desc
+);
+}
+}
+}
+
 functioncopyPrototype(src,dest,prefix){
 for(constkeyofReflect.ownKeys(src)){
 if(typeofkey==='string'){
@@ -135,5 +151,17 @@ primordials.SafePromise = makeSafe(
 copyPrototype(original.prototype,primordials,`${name}Prototype`);
 });
 
+// Create copies of intrinsic objects that require a valid `this` to call
+// static methods.
+// Refs: https://www.ecma-international.org/ecma-262/#sec-promise.all
+[
+'Promise',
+].forEach((name)=>{
+constoriginal=global[name];
+primordials[name]=original;
+copyPropsRenamedBound(original,primordials,name);
+copyPrototype(original.prototype,primordials,`${name}Prototype`);
+});
+
 Object.setPrototypeOf(primordials,null);
 Object.freeze(primordials);

lib/internal/process/execution.js

@@ -2,6 +2,7 @@
 
 const{
  JSONStringify,
+ PromiseResolve,
 }=primordials;
 
 constpath=require('path');
@@ -41,7 +42,7 @@ function evalModule(source, print){
 const{ log, error }=require('internal/console/global');
 const{ decorateErrorStack }=require('internal/util');
 constasyncESM=require('internal/process/esm_loader');
-Promise.resolve(asyncESM.ESMLoader).then(async(loader)=>{
+PromiseResolve(asyncESM.ESMLoader).then(async(loader)=>{
 const{ result }=awaitloader.eval(source);
 if(print){
 log(result);