src: cache the result of GetOptions() in JS land

Instead of calling into C++ each time we need to check the value of a command line option, cache the option map in a new `internal/options` module for faster access to the values in JS land. PR-URL: #24091 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Author: joyeecheung

lib/crypto.js

@@ -35,8 +35,8 @@ const{
 ERR_CRYPTO_FIPS_UNAVAILABLE
 }=require('internal/errors').codes;
 constconstants=internalBinding('constants').crypto;
-const{getOptions}=internalBinding('options');
-constpendingDeprecation=getOptions('--pending-deprecation');
+const{getOptionValue}=require('internal/options');
+constpendingDeprecation=getOptionValue('--pending-deprecation');
 const{
  fipsMode,
  fipsForced

lib/internal/bash_completion.js

@@ -1,8 +1,7 @@
 'use strict';
-const{getOptions }=internalBinding('options');
+const{options, aliases }=require('internal/options');
 
 functionprint(stream){
-const{ options, aliases }=getOptions();
 constall_opts=[...options.keys(), ...aliases.keys()];
 
 stream.write(`_node_complete(){

lib/internal/bootstrap/loaders.js

@@ -251,8 +251,7 @@
 
 NativeModule.isInternal=function(id){
 returnid.startsWith('internal/')||
-(id==='worker_threads'&&
-!internalBinding('options').getOptions('--experimental-worker'));
+(id==='worker_threads'&&!config.experimentalWorker);
 };
 }
 

lib/internal/bootstrap/node.js

@@ -103,12 +103,13 @@
 NativeModule.require('internal/inspector_async_hook').setup();
 }
 
-const{ getOptions }=internalBinding('options');
-consthelpOption=getOptions('--help');
-constcompletionBashOption=getOptions('--completion-bash');
-constexperimentalModulesOption=getOptions('--experimental-modules');
-constexperimentalVMModulesOption=getOptions('--experimental-vm-modules');
-constexperimentalWorkerOption=getOptions('--experimental-worker');
+const{ getOptionValue }=NativeModule.require('internal/options');
+consthelpOption=getOptionValue('--help');
+constcompletionBashOption=getOptionValue('--completion-bash');
+constexperimentalModulesOption=getOptionValue('--experimental-modules');
+constexperimentalVMModulesOption=
+getOptionValue('--experimental-vm-modules');
+constexperimentalWorkerOption=getOptionValue('--experimental-worker');
 if(helpOption){
 NativeModule.require('internal/print_help').print(process.stdout);
 return;
@@ -721,10 +722,9 @@
 
 constget=()=>{
 const{
- getOptions,
 envSettings: { kAllowedInEnvironment }
 }=internalBinding('options');
-const{ options, aliases }=getOptions();
+const{ options, aliases }=NativeModule.require('internal/options');
 
 constallowedNodeEnvironmentFlags=[];
 for(const[name,info]ofoptions){

lib/internal/modules/cjs/helpers.js

@@ -9,7 +9,7 @@ const{
 CHAR_HASH,
 }=require('internal/constants');
 
-const{getOptions}=internalBinding('options');
+const{getOptionValue}=require('internal/options');
 
 // Invoke with makeRequireFunction(module) where |module| is the Module object
 // to use as the context for the require() function.
@@ -107,7 +107,7 @@ const builtinLibs = [
 'v8','vm','zlib'
 ];
 
-if(getOptions('--experimental-worker')){
+if(getOptionValue('--experimental-worker')){
 builtinLibs.push('worker_threads');
 builtinLibs.sort();
 }

lib/internal/modules/cjs/loader.js

@@ -41,10 +41,10 @@ const{
  stripBOM,
  stripShebang
 }=require('internal/modules/cjs/helpers');
-constoptions=internalBinding('options');
-constpreserveSymlinks=options.getOptions('--preserve-symlinks');
-constpreserveSymlinksMain=options.getOptions('--preserve-symlinks-main');
-constexperimentalModules=options.getOptions('--experimental-modules');
+const{ getOptionValue }=require('internal/options');
+constpreserveSymlinks=getOptionValue('--preserve-symlinks');
+constpreserveSymlinksMain=getOptionValue('--preserve-symlinks-main');
+constexperimentalModules=getOptionValue('--experimental-modules');
 
 const{
 ERR_INVALID_ARG_TYPE,

lib/internal/modules/esm/default_resolve.js

@@ -6,9 +6,9 @@ const internalFS = require('internal/fs/utils');
 const{ NativeModule }=require('internal/bootstrap/loaders');
 const{ extname }=require('path');
 const{ realpathSync }=require('fs');
-const{getOptions}=internalBinding('options');
-constpreserveSymlinks=getOptions('--preserve-symlinks');
-constpreserveSymlinksMain=getOptions('--preserve-symlinks-main');
+const{getOptionValue}=require('internal/options');
+constpreserveSymlinks=getOptionValue('--preserve-symlinks');
+constpreserveSymlinksMain=getOptionValue('--preserve-symlinks-main');
 const{
 ERR_MISSING_MODULE,
 ERR_MODULE_RESOLUTION_LEGACY,

lib/internal/options.js

@@ -0,0 +1,18 @@
+'use strict';
+
+const{ getOptions }=internalBinding('options');
+const{ options, aliases }=getOptions();
+
+functiongetOptionValue(option){
+constresult=options.get(option);
+if(!result){
+returnundefined;
+}
+returnresult.value;
+}
+
+module.exports={
+ options,
+ aliases,
+ getOptionValue
+};

lib/internal/print_help.js

@@ -1,5 +1,6 @@
 'use strict';
-const{ getOptions, types }=internalBinding('options');
+
+const{ types }=internalBinding('options');
 
 consttypeLookup=[];
 for(constkeyofObject.keys(types))
@@ -132,7 +133,7 @@ function format({options, aliases = new Map(), firstColumn, secondColumn }){
 }
 
 functionprint(stream){
-const{ options, aliases }=getOptions();
+const{ options, aliases }=require('internal/options');
 
 // Use 75 % of the available width, and at least 70 characters.
 constwidth=Math.max(70,(stream.columns||0)*0.75);

lib/internal/process/esm_loader.js

@@ -48,7 +48,7 @@ exports.ESMLoader = undefined;
 exports.setup=function(){
 letESMLoader=newLoader();
 constloaderPromise=(async()=>{
-constuserLoader=internalBinding('options').getOptions('--loader');
+constuserLoader=require('internal/options').getOptionValue('--loader');
 if(userLoader){
 consthooks=awaitESMLoader.import(
 userLoader,pathToFileURL(`${process.cwd()}/`).href);