tools: prefer common.expectsError in tests

Add lint rule to validate that common.expectsError(fn, err) is being used instead of assert.throws(fn, common.expectsError(err)); PR-URL: #17557 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: apapirovski

test/.eslintrc.yaml

@@ -10,6 +10,7 @@ rules:
 # Custom rules in tools/eslint-rules
 prefer-assert-iferror: error
 prefer-assert-methods: error
+prefer-common-expectserror: error
 prefer-common-mustnotcall: error
 crypto-check: error
 inspector-check: error

test/parallel/test-eslint-prefer-common-expectserror.js

@@ -0,0 +1,27 @@
+'use strict';
+
+require('../common');
+
+constRuleTester=require('../../tools/eslint').RuleTester;
+construle=require('../../tools/eslint-rules/prefer-common-expectserror');
+
+constmessage='Please use common.expectsError(fn, err) instead of '+
+'assert.throws(fn, common.expectsError(err)).';
+
+newRuleTester().run('prefer-common-expectserror',rule,{
+valid: [
+'assert.throws(fn, /[a-z]/)',
+'assert.throws(function (){}, function(){})',
+'common.expectsError(function(){}, err)'
+],
+invalid: [
+{
+code: 'assert.throws(function(){}, common.expectsError(err))',
+errors: [{ message }]
+},
+{
+code: 'assert.throws(fn, common.expectsError(err))',
+errors: [{ message }]
+}
+]
+});

tools/eslint-rules/prefer-common-expectserror.js

@@ -0,0 +1,21 @@
+'use strict';
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+constmsg='Please use common.expectsError(fn, err) instead of '+
+'assert.throws(fn, common.expectsError(err)).';
+
+constastSelector=
+'CallExpression[arguments.length=2]'+
+'[callee.object.name="assert"]'+
+'[callee.property.name="throws"]'+
+'[arguments.1.callee.object.name="common"]'+
+'[arguments.1.callee.property.name="expectsError"]';
+
+module.exports=function(context){
+return{
+[astSelector]: (node)=>context.report(node,msg)
+};
+};