crypto: remove default encoding from cipher

tniessen · targos · commit ac8dd61fc34e · 2023-05-30T11:36:10.000+02:00
Refs: #47182 PR-URL: #47998 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/crypto/cipher.js b/lib/internal/crypto/cipher.js
@@ -45,7 +45,6 @@ const{
 } = require('internal/crypto/keys');
 
 const{
- getDefaultEncoding,
 getArrayBufferOrView,
 getStringOption,
 kHandle,
@@ -172,10 +171,6 @@ Cipher.prototype._flush = function _flush(callback){
 };
 
 Cipher.prototype.update = function update(data, inputEncoding, outputEncoding){
- const encoding = getDefaultEncoding();
- inputEncoding = inputEncoding || encoding;
- outputEncoding = outputEncoding || encoding;
-
 if (typeof data === 'string'){
 validateEncoding(data, inputEncoding);
 } else if (!isArrayBufferView(data)){
@@ -195,7 +190,6 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding){
 
 
 Cipher.prototype.final = function final(outputEncoding){
- outputEncoding = outputEncoding || getDefaultEncoding();
 const ret = this[kHandle].final();
 
 if (outputEncoding && outputEncoding !== 'buffer'){

-Original file line number
+Diff line change
 }=require('internal/crypto/keys');
 const{
 - getDefaultEncoding,
  getArrayBufferOrView,
  getStringOption,
  kHandle,
 };
 Cipher.prototype.update=functionupdate(data,inputEncoding,outputEncoding){
 -constencoding=getDefaultEncoding();
 -inputEncoding=inputEncoding||encoding;
 -outputEncoding=outputEncoding||encoding;
+-
 if(typeofdata==='string'){
 validateEncoding(data,inputEncoding);
 }elseif(!isArrayBufferView(data)){
 Cipher.prototype.final=functionfinal(outputEncoding){
 -outputEncoding=outputEncoding||getDefaultEncoding();
 constret=this[kHandle].final();
 if(outputEncoding&&outputEncoding!=='buffer'){