build: upgrade Python linter ruff, add rules ASYNC,PERF

PR-URL: #59984 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Author: cclauss

Makefile

@@ -1563,8 +1563,8 @@ cpplint: lint-cpp
 # Try with '--system' if it fails without; the system may have set '--user'
 lint-py-build: ## Build resources needed to lint python files.
 $(info Pip installing ruff on $(shell$(PYTHON) --version)...)
-$(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.6.5||\
-$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.6.5
+$(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.13.1||\
+$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.13.1
 
 .PHONY: lint-py lint-py-fix lint-py-fix-unsafe
 ifneq ("","$(wildcard tools/pip/site-packages/ruff)")
@@ -1574,7 +1574,6 @@ lint-py:
  tools/pip/site-packages/bin/ruff check .
 lint-py-fix:
  tools/pip/site-packages/bin/ruff check . --fix
-
 lint-py-fix-unsafe:
  tools/pip/site-packages/bin/ruff check . --fix --unsafe-fixes
 else

pyproject.toml

@@ -11,11 +11,13 @@ target-version = "py39"
 
 [tool.ruff.lint]
 select = [
+"ASYNC", # flake8-async
 "C90", # McCabe cyclomatic complexity
 "E", # pycodestyle
 "F", # Pyflakes
 "ICN", # flake8-import-conventions
 "INT", # flake8-gettext
+"PERF", # flake8-performance
 "PLC", # Pylint conventions
 "PLE", # Pylint errors
 "PLR09", # Pylint refactoring: max-args, max-branches, max returns, max-statements
@@ -32,6 +34,7 @@ ignore = [
 "E401",
 "E402",
 "E7",
+"PLC0415",
 "RUF005",
 ]
 

test/testpy/__init__.py

@@ -165,9 +165,7 @@ def SelectTest(name):
 result= []
 forsubpathinos.listdir(path):
 ifos.path.isdir(os.path.join(path, subpath)):
-forfinos.listdir(os.path.join(path, subpath)):
-ifSelectTest(f):
-result.append([subpath, f[:-3]])
+result.extend([subpath, f[:-3]] forfinos.listdir(os.path.join(path, subpath)) ifSelectTest(f))
 returnresult
 
 defListTests(self, current_path, path, arch, mode):

test/tools/test_checkimports.py

@@ -28,7 +28,7 @@ class CheckImportsTest(unittest.TestCase):
 'test', 'fixtures', 'tools', 'checkimports')
 
 deftest_unused_and_unsorted(self):
-withcaptured_output() as (out, err):
+withcaptured_output() as (out, _err):
 self.assertEqual(is_valid(path.join(self.fixturesDir, 'invalid.cc')),
 False)
 output=out.getvalue()
@@ -42,21 +42,21 @@ def test_unused_and_unsorted(self):
 output);
 
 deftest_unused_complex(self):
-withcaptured_output() as (out, err):
+withcaptured_output() as (out, _err):
 self.assertEqual(is_valid(path.join(self.fixturesDir, 'maybe.cc')),
 False)
 output=out.getvalue()
 self.assertIn('does not use "Local"', output);
 
 deftest_unused_simple(self):
-withcaptured_output() as (out, err):
+withcaptured_output() as (out, _err):
 self.assertEqual(is_valid(path.join(self.fixturesDir, 'unused.cc')),
 False)
 output=out.getvalue()
 self.assertIn('does not use "Context"', output);
 
 deftest_unsorted(self):
-withcaptured_output() as (out, err):
+withcaptured_output() as (out, _err):
 self.assertEqual(is_valid(path.join(self.fixturesDir, 'unsorted.cc')),
 False)
 output=out.getvalue()
@@ -67,7 +67,7 @@ def test_unsorted(self):
 output);
 
 deftest_valid(self):
-withcaptured_output() as (out, err):
+withcaptured_output() as (out, _err):
 self.assertEqual(is_valid(path.join(self.fixturesDir, 'valid.cc')),
 True)
 output=out.getvalue()

tools/generate_config_gypi.py

@@ -95,7 +95,7 @@ def main():
 default='//node')
 parser.add_argument('--dep-file', help='path to an optional dep file',
 default=None)
-args, unknown_args=parser.parse_known_args()
+args, _unknown_args=parser.parse_known_args()
 
 config=get_gn_config(args.out_dir)
 v8_config=get_v8_config(args.out_dir, args.node_gn_path)

tools/icu/icutrim.py

@@ -339,17 +339,17 @@ def removeList(count=0):
 removeList(1)
 
 # now, fixup res_index, one at a time
-fortreeintrees:
+fortree, valueintrees.items():
 # skip trees that don't have res_index
-if"hasIndex"notintrees[tree]:
+if"hasIndex"notinvalue:
 continue
 treebunddir=options.tmpdir
-if(trees[tree]["treeprefix"]):
-treebunddir=os.path.join(treebunddir, trees[tree]["treeprefix"])
+if(value["treeprefix"]):
+treebunddir=os.path.join(treebunddir, value["treeprefix"])
 ifnot (os.path.isdir(treebunddir)):
 os.mkdir(treebunddir)
 treebundres=os.path.join(treebunddir,RES_INDX)
 treebundtxt="%s.txt"% (treebundres[0:-4])
 runcmd("iculslocs", "-i %s -N %s -T %s -b %s"% (outfile, dataname, tree, treebundtxt))
 runcmd("genrb","-d %s -s %s res_index.txt"% (treebunddir, treebunddir))
-runcmd("icupkg","-s %s -a %s%s %s"% (options.tmpdir, trees[tree]["treeprefix"], RES_INDX, outfile))
+runcmd("icupkg","-s %s -a %s%s %s"% (options.tmpdir, value["treeprefix"], RES_INDX, outfile))

tools/install.py

@@ -73,7 +73,7 @@ def try_copy(options, path, dest):
 returnshutil.copy2(source_path, target_path)
 
 deftry_remove(options, path, dest):
-source_path, target_path=mkpaths(options, path, dest)
+_source_path, target_path=mkpaths(options, path, dest)
 ifnotoptions.silent:
 print('removing %s'%target_path)
 try_unlink(target_path)

tools/test.py

@@ -817,7 +817,7 @@ def setResourceLimits():
 else:
 preexec_fn=setMaxVirtualMemory
 
- (process, exit_code, timed_out) =RunProcess(
+ (_process, exit_code, timed_out) =RunProcess(
 context,
 timeout,
 args=args,
@@ -924,7 +924,7 @@ def GetBuildRequirements(self, path, context):
 returnresult
 
 defListTests(self, current_path, path, context, arch, mode):
- (name, rest) =CarCdr(path)
+ (name, _rest) =CarCdr(path)
 result= [ ]
 fortestinself.tests_repos:
 test_name=test.GetName()