module: only set cache when finding module succeeds

PR-URL: #36642Fixes: #36638 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: zhangyongsheng

benchmark/module/module-require.js

@@ -0,0 +1,80 @@
+'use strict';
+
+constfs=require('fs');
+constpath=require('path');
+constcommon=require('../common.js');
+consttmpdir=require('../../test/common/tmpdir');
+constbenchmarkDirectory=path.join(tmpdir.path,'nodejs-benchmark-module');
+
+constbench=common.createBenchmark(main,{
+type: ['.js','.json','dir'],
+n: [1e4],
+});
+
+functionmain({ type, n }){
+tmpdir.refresh();
+createEntryPoint(n);
+
+switch(type){
+case'.js':
+measureJSFile(n);
+break;
+case'.json':
+measureJSONFile(n);
+break;
+case'dir':
+measureDir(n);
+}
+
+tmpdir.refresh();
+}
+
+functionmeasureJSFile(n){
+bench.start();
+for(leti=0;i<n;i++){
+require(`${benchmarkDirectory}/${i}`);
+}
+bench.end(n);
+}
+
+functionmeasureJSONFile(n){
+bench.start();
+for(leti=0;i<n;i++){
+require(`${benchmarkDirectory}/json_${i}.json`);
+}
+bench.end(n);
+}
+
+functionmeasureDir(n){
+bench.start();
+for(leti=0;i<n;i++){
+require(`${benchmarkDirectory}${i}`);
+}
+bench.end(n);
+}
+
+functioncreateEntryPoint(n){
+fs.mkdirSync(benchmarkDirectory);
+
+constJSFileContent='module.exports = [];';
+constJSONFileContent='[]';
+
+for(leti=0;i<n;i++){
+// JS file.
+fs.writeFileSync(`${benchmarkDirectory}/${i}.js`,JSFileContent);
+
+// JSON file.
+fs.writeFileSync(`${benchmarkDirectory}/json_${i}.json`,JSONFileContent);
+
+// Dir.
+fs.mkdirSync(`${benchmarkDirectory}${i}`);
+fs.writeFileSync(
+`${benchmarkDirectory}${i}/package.json`,
+'{"main": "index.js"}'
+);
+fs.writeFileSync(
+`${benchmarkDirectory}${i}/index.js`,
+JSFileContent
+);
+}
+}

lib/internal/modules/cjs/loader.js

@@ -148,7 +148,10 @@ function stat(filename){
 if(result!==undefined)returnresult;
 }
 constresult=internalModuleStat(filename);
-if(statCache!==null)statCache.set(filename,result);
+if(statCache!==null&&result>=0){
+// Only set cache when `internalModuleStat(filename)` succeeds.
+statCache.set(filename,result);
+}
 returnresult;
 }
 

test/parallel/test-module-cache.js

@@ -0,0 +1,19 @@
+'use strict';
+require('../common');
+constassert=require('assert');
+constfs=require('fs');
+constpath=require('path');
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
+constfilePath=path.join(tmpdir.path,'test-module-cache.json');
+assert.throws(
+()=>require(filePath),
+{code: 'MODULE_NOT_FOUND'}
+);
+
+fs.writeFileSync(filePath,'[]');
+
+constcontent=require(filePath);
+assert.strictEqual(Array.isArray(content),true);
+assert.strictEqual(content.length,0);