lib: add brand checks to AbortController and AbortSignal

PR-URL: #37720 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: MattiasBuelens

lib/internal/abort_controller.js

@@ -23,6 +23,11 @@ const{
  customInspectSymbol,
 }=require('internal/util');
 const{ inspect }=require('internal/util/inspect');
+const{
+codes: {
+ERR_INVALID_THIS,
+}
+}=require('internal/errors');
 
 constkAborted=Symbol('kAborted');
 
@@ -37,13 +42,21 @@ function customInspect(self, obj, depth, options){
 return`${self.constructor.name}${inspect(obj,opts)}`;
 }
 
+functionvalidateAbortSignal(obj){
+if(obj?.[kAborted]===undefined)
+thrownewERR_INVALID_THIS('AbortSignal');
+}
+
 classAbortSignalextendsEventTarget{
 constructor(){
 // eslint-disable-next-line no-restricted-syntax
 thrownewTypeError('Illegal constructor');
 }
 
-getaborted(){return!!this[kAborted];}
+getaborted(){
+validateAbortSignal(this);
+return!!this[kAborted];
+}
 
 [customInspectSymbol](depth,options){
 returncustomInspect(this,{
@@ -89,13 +102,26 @@ function abortSignal(signal){
 // initializers for now:
 // https://bugs.chromium.org/p/v8/issues/detail?id=10704
 constkSignal=Symbol('signal');
+
+functionvalidateAbortController(obj){
+if(obj?.[kSignal]===undefined)
+thrownewERR_INVALID_THIS('AbortController');
+}
+
 classAbortController{
 constructor(){
 this[kSignal]=createAbortSignal();
 }
 
-getsignal(){returnthis[kSignal];}
-abort(){abortSignal(this[kSignal]);}
+getsignal(){
+validateAbortController(this);
+returnthis[kSignal];
+}
+
+abort(){
+validateAbortController(this);
+abortSignal(this[kSignal]);
+}
 
 [customInspectSymbol](depth,options){
 returncustomInspect(this,{

test/parallel/test-abortcontroller.js

@@ -72,3 +72,63 @@ const{ok, strictEqual, throws } = require('assert');
 constsignal=AbortSignal.abort();
 ok(signal.aborted);
 }
+
+{
+// Test that AbortController properties and methods validate the receiver
+constacSignalGet=Object.getOwnPropertyDescriptor(
+AbortController.prototype,
+'signal'
+).get;
+constacAbort=AbortController.prototype.abort;
+
+constgoodController=newAbortController();
+ok(acSignalGet.call(goodController));
+acAbort.call(goodController);
+
+constbadAbortControllers=[
+null,
+undefined,
+0,
+NaN,
+true,
+'AbortController',
+Object.create(AbortController.prototype)
+];
+for(constbadControllerofbadAbortControllers){
+throws(
+()=>acSignalGet.call(badController),
+{code: 'ERR_INVALID_THIS',name: 'TypeError'}
+);
+throws(
+()=>acAbort.call(badController),
+{code: 'ERR_INVALID_THIS',name: 'TypeError'}
+);
+}
+}
+
+{
+// Test that AbortSignal properties validate the receiver
+constsignalAbortedGet=Object.getOwnPropertyDescriptor(
+AbortSignal.prototype,
+'aborted'
+).get;
+
+constgoodSignal=newAbortController().signal;
+strictEqual(signalAbortedGet.call(goodSignal),false);
+
+constbadAbortSignals=[
+null,
+undefined,
+0,
+NaN,
+true,
+'AbortSignal',
+Object.create(AbortSignal.prototype)
+];
+for(constbadSignalofbadAbortSignals){
+throws(
+()=>signalAbortedGet.call(badSignal),
+{code: 'ERR_INVALID_THIS',name: 'TypeError'}
+);
+}
+}