util: do not catch on circular @@toStringTag errors

PR-URL: #55544Fixes: #55539 Reviewed-By: James M Snell <[email protected]> Co-Authored-By: Colin Ihrig <[email protected]>

Author: 2 people

lib/internal/util/inspect.js

@@ -1062,6 +1062,7 @@ function formatRaw(ctx, value, recurseTimes, typedArray){
 ArrayPrototypePushApply(output,protoProps);
 }
 }catch(err){
+if(!isStackOverflowError(err))throwerr;
 constconstructorName=StringPrototypeSlice(getCtxStyle(value,constructor,tag),0,-1);
 returnhandleMaxCallStackSize(ctx,err,constructorName,indentationLvl);
 }
@@ -1547,17 +1548,13 @@ function groupArrayElements(ctx, output, value){
 }
 
 functionhandleMaxCallStackSize(ctx,err,constructorName,indentationLvl){
-if(isStackOverflowError(err)){
-ctx.seen.pop();
-ctx.indentationLvl=indentationLvl;
-returnctx.stylize(
-`[${constructorName}: Inspection interrupted `+
-'prematurely. Maximum call stack size exceeded.]',
-'special',
-);
-}
-/* c8 ignore next */
-assert.fail(err.stack);
+ctx.seen.pop();
+ctx.indentationLvl=indentationLvl;
+returnctx.stylize(
+`[${constructorName}: Inspection interrupted `+
+'prematurely. Maximum call stack size exceeded.]',
+'special',
+);
 }
 
 functionaddNumericSeparator(integerString){

test/parallel/test-util-inspect.js

@@ -1644,6 +1644,15 @@ util.inspect(process);
 
 assert.throws(()=>util.inspect(newThrowingClass()),/toStringTagerror/);
 
+consty={
+get[Symbol.toStringTag](){
+returnJSON.stringify(this);
+}
+};
+constx={ y };
+y.x=x;
+assert.throws(()=>util.inspect(x),/TypeError:ConvertingcircularstructuretoJSON/);
+
 classNotStringClass{
 get[Symbol.toStringTag](){
 returnnull;