test: Update test-http-parser-free to use countdown timer

daxlab · MylesBorins · commit b033d38022ca · 2017-12-12T03:27:42.000-05:00
PR-URL: #17322 Refs: #17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-http-parser-free.js b/test/parallel/test-http-parser-free.js
@@ -23,13 +23,15 @@
 require('../common');
 const assert = require('assert');
 const http = require('http');
+const Countdown = require('../common/countdown');
 const N = 100;
-let responses = 0;
 
 const server = http.createServer(function(req, res){
 res.end('Hello');
 });
 
+const countdown = new Countdown(N, () => server.close());
+
 server.listen(0, function(){
 http.globalAgent.maxSockets = 1;
 let parser;
@@ -42,15 +44,9 @@ server.listen(0, function(){
 assert.strictEqual(req.parser, parser);
 }
 
- if (++responses === N){
- server.close();
- }
+ countdown.dec();
 res.resume();
 });
 })(i);
 }
 });
-
-process.on('exit', function(){
- assert.strictEqual(responses, N);
-});

-Original file line number
+Diff line change
 require('../common');
 constassert=require('assert');
 consthttp=require('http');
 +constCountdown=require('../common/countdown');
 constN=100;
 -letresponses=0;
 constserver=http.createServer(function(req,res){
 res.end('Hello');
 });
 +constcountdown=newCountdown(N,()=>server.close());
++
 server.listen(0,function(){
 http.globalAgent.maxSockets=1;
 letparser;
 assert.strictEqual(req.parser,parser);
+}
 -if(++responses===N){
 -server.close();
 -}
 +countdown.dec();
 res.resume();
 });
 })(i);
+}
 });
+-
 -process.on('exit',function(){
 -assert.strictEqual(responses,N);
 -});