test: use mustSucceed in test-repl-tab-complete-import

Refactor test/parallel/test-repl-tab-complete-import.js to use mustSucceed in places where no error is expected in the callback. This clarifies the intent of the tests and improves assertion accuracy. Refs: #59204 PR-URL: #59368 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: KimSH39

test/parallel/test-repl-tab-complete-import.js

@@ -32,8 +32,7 @@ const testMe = repl.start({
 testMe._domain.on('error',assert.ifError);
 
 // Tab complete provides built in libs for import()
-testMe.complete('import(\'',common.mustCall((error,data)=>{
-assert.strictEqual(error,null);
+testMe.complete('import(\'',common.mustSucceed((data)=>{
 publicUnprefixedModules.forEach((lib)=>{
 assert(
 data[0].includes(lib)&&data[0].includes(`node:${lib}`),
@@ -43,15 +42,14 @@ testMe.complete('import(\'', common.mustCall((error, data) =>{
 constnewModule='foobar';
 assert(!builtinModules.includes(newModule));
 repl.builtinModules.push(newModule);
-testMe.complete('import(\'',common.mustCall((_,[modules])=>{
+testMe.complete('import(\'',common.mustSucceed(([modules])=>{
 assert.strictEqual(data[0].length+1,modules.length);
 assert(modules.includes(newModule)&&
 !modules.includes(`node:${newModule}`));
 }));
 }));
 
-testMe.complete("import\t( 'n",common.mustCall((error,data)=>{
-assert.strictEqual(error,null);
+testMe.complete("import\t( 'n",common.mustSucceed((data)=>{
 assert.strictEqual(data.length,2);
 assert.strictEqual(data[1],'n');
 constcompletions=data[0];
@@ -77,16 +75,14 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) =>{
 // Import calls should handle all types of quotation marks.
 for(constquotationMarkof["'",'"','`']){
 putIn.run(['.clear']);
-testMe.complete('import(`@nodejs',common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete('import(`@nodejs',common.mustSucceed((data)=>{
 assert.deepStrictEqual(data,[expected,'@nodejs']);
 }));
 
 putIn.run(['.clear']);
 // Completions should not be greedy in case the quotation ends.
 constinput=`import(${quotationMark}@nodejsscope${quotationMark}`;
-testMe.complete(input,common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete(input,common.mustSucceed((data)=>{
 assert.deepStrictEqual(data,[[],undefined]);
 }));
 }
@@ -96,8 +92,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) =>{
 putIn.run(['.clear']);
 // Completions should find modules and handle whitespace after the opening
 // bracket.
-testMe.complete('import \t("no_ind',common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete('import \t("no_ind',common.mustSucceed((data)=>{
 assert.deepStrictEqual(data,[['no_index','no_index/'],'no_ind']);
 }));
 }
@@ -110,8 +105,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) =>{
 process.chdir(__dirname);
 
 ['import(\'.','import(".'].forEach((input)=>{
-testMe.complete(input,common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete(input,common.mustSucceed((data)=>{
 assert.strictEqual(data.length,2);
 assert.strictEqual(data[1],'.');
 assert.strictEqual(data[0].length,2);
@@ -121,16 +115,14 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) =>{
 });
 
 ['import(\'..','import("..'].forEach((input)=>{
-testMe.complete(input,common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete(input,common.mustSucceed((data)=>{
 assert.deepStrictEqual(data,[['../'],'..']);
 }));
 });
 
 ['./','./test-'].forEach((path)=>{
 [`import('${path}`,`import("${path}`].forEach((input)=>{
-testMe.complete(input,common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete(input,common.mustSucceed((data)=>{
 assert.strictEqual(data.length,2);
 assert.strictEqual(data[1],path);
 assert.ok(data[0].includes('./test-repl-tab-complete.js'));
@@ -140,8 +132,7 @@ testMe.complete("import\t( 'n", common.mustCall((error, data) =>{
 
 ['../parallel/','../parallel/test-'].forEach((path)=>{
 [`import('${path}`,`import("${path}`].forEach((input)=>{
-testMe.complete(input,common.mustCall((err,data)=>{
-assert.strictEqual(err,null);
+testMe.complete(input,common.mustSucceed((data)=>{
 assert.strictEqual(data.length,2);
 assert.strictEqual(data[1],path);
 assert.ok(data[0].includes('../parallel/test-repl-tab-complete.js'));