test: fix compiler warnings in callback-scope

Currently there are two compiler warnings generated from the addons test callback-scope: ../binding.cc:44:10: warning: 'Resolve' is deprecated [-Wdeprecated-declarations] local->Resolve(v8::Undefined(isolate)); ^ ../../../../deps/v8/include/v8.h:3893:45: note: 'Resolve' has been explicitly marked deprecated here V8_DEPRECATED("Use maybe version", void Resolve(Local<Value> value)); ^ ../binding.cc:52:54: warning: 'New' is deprecated [-Wdeprecated-declarations] persistent.Reset(isolate, v8::Promise::Resolver::New(isolate)); ^ ../../../../deps/v8/include/v8.h:3880:42: note: 'New' has been explicitly marked deprecated here Local<Resolver> New(Isolate* isolate)); This commit updates the test to use non-deprecated functions. PR-URL: #19252 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Author: danbev

test/addons/callback-scope/binding.cc

@@ -41,15 +41,17 @@ static void Callback(uv_work_t* req, int ignored){
 
  v8::Local<v8::Promise::Resolver> local =
  v8::Local<v8::Promise::Resolver>::New(isolate, persistent);
- local->Resolve(v8::Undefined(isolate));
+ local->Resolve(isolate->GetCurrentContext(),
+v8::Undefined(isolate)).ToChecked();
 delete req;
 }
 
 staticvoidTestResolveAsync(const v8::FunctionCallbackInfo<v8::Value>& args){
  v8::Isolate* isolate = args.GetIsolate();
 
 if (persistent.IsEmpty()){
- persistent.Reset(isolate, v8::Promise::Resolver::New(isolate));
+ persistent.Reset(isolate, v8::Promise::Resolver::New(
+ isolate->GetCurrentContext()).ToLocalChecked());
 
 uv_work_t* req = newuv_work_t;