tools: enable no-useless-return eslint rule

PR-URL: #12577 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>

Author: cjihrig

.eslintrc.yaml

@@ -45,6 +45,7 @@ rules:
 no-unused-labels: 2
 no-useless-call: 2
 no-useless-escape: 2
+no-useless-return: 2
 no-void: 2
 no-with: 2
 

doc/api/errors.md

@@ -64,6 +64,7 @@ Errors that occur within _Asynchronous APIs_ may be reported in multiple ways:
  argument is not `null` and is an instance of `Error`, then an error occurred
  that should be handled.
 
+<!-- eslint-disable no-useless-return -->
 ```js
 constfs=require('fs');
 fs.readFile('a file that does not exist', (err, data) =>{

doc/api/stream.md

@@ -1548,6 +1548,7 @@ unexpected and inconsistent behavior depending on whether the stream is
 operating in flowing or paused mode. Using the `'error'` event ensures
 consistent and predictable handling of errors.
 
+<!-- eslint-disable no-useless-return -->
 ```js
 constReadable=require('stream').Readable;
 

lib/dgram.js

@@ -286,7 +286,6 @@ function enqueue(self, toEnqueue){
 self.once('listening',clearQueue);
 }
 self._queue.push(toEnqueue);
-return;
 }
 
 

test/parallel/test-fs-symlink.js

@@ -14,7 +14,6 @@ if (common.isWindows){
 exec('whoami /priv',function(err,o){
 if(err||!o.includes('SeCreateSymbolicLinkPrivilege')){
 common.skip('insufficient privileges');
-return;
 }
 });
 }

test/parallel/test-require-symlink.js

@@ -29,9 +29,9 @@ if (common.isWindows){
 if(err||!o.includes('SeCreateSymbolicLinkPrivilege')){
 common.skip('insufficient privileges');
 return;
-}else{
-test();
 }
+
+test();
 });
 }else{
 test();

tools/doc/json.js

@@ -222,7 +222,6 @@ function processList(section){
 current.options.push(n);
 current=n;
 }
-return;
 }elseif(type==='list_item_end'){
 if(!current){
 thrownewError('invalid list - end without current item\n'+
@@ -499,9 +498,6 @@ function finishSection(section, parent){
 parent[k]=parent[k].concat(section[k]);
 }elseif(!parent[k]){
 parent[k]=section[k];
-}else{
-// parent already has, and it's not an array.
-return;
 }
 }
 });