tls: catch certCbDone exceptions

Catch and emit `certCbDone` exceptions instead of throwing them as `uncaughtException` and crashing the whole process. Fix: #6822 PR-URL: #6887 Reviewed-By: Ben Noordhuis <[email protected]>

Author: indutny

lib/_tls_wrap.js

@@ -184,7 +184,11 @@ function oncertcb(info){
 if(!self._handle)
 returnself.destroy(newError('Socket is closed'));
 
-self._handle.certCbDone();
+try{
+self._handle.certCbDone();
+}catch(e){
+self.destroy(e);
+}
 });
 });
 }

test/parallel/test-tls-empty-sni-context.js

@@ -0,0 +1,42 @@
+'use strict';
+
+if(!process.features.tls_sni){
+console.log('1..0 # Skipped: node compiled without OpenSSL or '+
+'with old OpenSSL version.');
+return;
+}
+
+constcommon=require('../common');
+constassert=require('assert');
+
+if(!common.hasCrypto){
+console.log('1..0 # Skipped: missing crypto');
+return;
+}
+
+consttls=require('tls');
+
+constoptions={
+SNICallback: (name,callback)=>{
+callback(null,tls.createSecureContext());
+}
+};
+
+constserver=tls.createServer(options,(c)=>{
+common.fail('Should not be called');
+}).on('clientError',common.mustCall((err,c)=>{
+assert(/SSL_use_certificate:passedanullparameter/i.test(err.message));
+server.close();
+})).listen(common.PORT,common.mustCall(()=>{
+constc=tls.connect({
+port: common.PORT,
+rejectUnauthorized: false,
+servername: 'any.name'
+},()=>{
+common.fail('Should not be called');
+});
+
+c.on('error',common.mustCall((err)=>{
+assert(/sockethangup/.test(err.message));
+}));
+}));