url: error when domainTo*() is called w/o argument

TimothyGu · evanlucas · commit b9b93f2165bb · 2017-05-01T11:16:06.000-05:00
PR-URL: #12507 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1308,11 +1308,17 @@ function originFor(url, base){
 }
 
 function domainToASCII(domain){
+ if (arguments.length < 1)
+ throw new TypeError('"domain" argument must be specified');
+
 // toUSVString is not needed.
 return binding.domainToASCII(`${domain}`);
 }
 
 function domainToUnicode(domain){
+ if (arguments.length < 1)
+ throw new TypeError('"domain" argument must be specified');
+
 // toUSVString is not needed.
 return binding.domainToUnicode(`${domain}`);
 }
diff --git a/test/parallel/test-whatwg-url-domainto.js b/test/parallel/test-whatwg-url-domainto.js
@@ -12,6 +12,15 @@ const{domainToASCII, domainToUnicode } = require('url');
 // Tests below are not from WPT.
 const tests = require('../fixtures/url-idna.js');
 
+{
+ assert.throws(() => domainToASCII(),
+ /^TypeError: "domain" argument must be specified$/);
+ assert.throws(() => domainToUnicode(),
+ /^TypeError: "domain" argument must be specified$/);
+ assert.strictEqual(domainToASCII(undefined), 'undefined');
+ assert.strictEqual(domainToUnicode(undefined), 'undefined');
+}
+
{
 for (const [i,{ascii, unicode }] of tests.valid.entries()){
 assert.strictEqual(ascii, domainToASCII(unicode),

Original file line number	Diff line number	Diff line change
`@@ -1308,11 +1308,17 @@ function originFor(url, base){`
`1308`	`1308`	`}`
`1309`	`1309`
`1310`	`1310`	`functiondomainToASCII(domain){`
	`1311`	`+if(arguments.length<1)`
	`1312`	`+thrownewTypeError('"domain" argument must be specified');`
	`1313`	`+`
`1311`	`1314`	`// toUSVString is not needed.`
`1312`	`1315`	returnbinding.domainToASCII(`${domain}`);
`1313`	`1316`	`}`
`1314`	`1317`
`1315`	`1318`	`functiondomainToUnicode(domain){`
	`1319`	`+if(arguments.length<1)`
	`1320`	`+thrownewTypeError('"domain" argument must be specified');`
	`1321`	`+`
`1316`	`1322`	`// toUSVString is not needed.`
`1317`	`1323`	returnbinding.domainToUnicode(`${domain}`);
`1318`	`1324`	`}`
-Original file line number
+Diff line change
 // Tests below are not from WPT.
 consttests=require('../fixtures/url-idna.js');
 +{
 +assert.throws(()=>domainToASCII(),
 +/^TypeError:"domain"argumentmustbespecified$/);
 +assert.throws(()=>domainToUnicode(),
 +/^TypeError:"domain"argumentmustbespecified$/);
 +assert.strictEqual(domainToASCII(undefined),'undefined');
 +assert.strictEqual(domainToUnicode(undefined),'undefined');
 +}
++
+{
 for(const[i,{ ascii, unicode }]oftests.valid.entries()){
 assert.strictEqual(ascii,domainToASCII(unicode),