Skip to content

Commit ba18406

Browse files
mcollinaBethGriggs
authored andcommitted
tls: implement capture rejections for 'secureConnection' event
PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 75972da commit ba18406

File tree

2 files changed

+48
-0
lines changed

2 files changed

+48
-0
lines changed

‎lib/_tls_wrap.js‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ assertCrypto();
3838
const{ setImmediate }=require('timers');
3939
constassert=require('internal/assert');
4040
constcrypto=require('crypto');
41+
constEE=require('events');
4142
constnet=require('net');
4243
consttls=require('tls');
4344
constcommon=require('_tls_common');
@@ -1395,6 +1396,19 @@ Server.prototype.addContext = function(servername, context){
13951396
this._contexts.push([re,tls.createSecureContext(context).context]);
13961397
};
13971398

1399+
Server.prototype[EE.captureRejectionSymbol]=function(
1400+
err,event,sock){
1401+
1402+
switch(event){
1403+
case'secureConnection':
1404+
sock.destroy(err);
1405+
break;
1406+
default:
1407+
net.Server.prototype[Symbol.for('nodejs.rejection')]
1408+
.call(this,err,event,sock);
1409+
}
1410+
};
1411+
13981412
functionSNICallback(servername,callback){
13991413
constcontexts=this.server._contexts;
14001414

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.hasCrypto)
5+
common.skip('missing crypto');
6+
7+
constassert=require('assert');
8+
constevents=require('events');
9+
constfixtures=require('../common/fixtures');
10+
const{ createServer, connect }=require('tls');
11+
constcert=fixtures.readKey('rsa_cert.crt');
12+
constkey=fixtures.readKey('rsa_private.pem');
13+
14+
events.captureRejections=true;
15+
16+
constserver=createServer({ cert, key },common.mustCall(async(sock)=>{
17+
server.close();
18+
19+
const_err=newError('kaboom');
20+
sock.on('error',common.mustCall((err)=>{
21+
assert.strictEqual(err,_err);
22+
}));
23+
throw_err;
24+
}));
25+
26+
server.listen(0,common.mustCall(()=>{
27+
constsock=connect({
28+
port: server.address().port,
29+
host: server.address().host,
30+
rejectUnauthorized: false
31+
});
32+
33+
sock.on('close',common.mustCall());
34+
}));

0 commit comments

Comments
(0)