url: refactor validateHostname

This function did not only validate the input but it returned a new value in case the hostname was valid. This simplifies the function by always returning the required value, no matter if it is valid or invalid, so the callee site does not have to check that anymore. On top the function is renamed to `getHostname` to make clear that the function does not only validate the input but it also returns a new value. PR-URL: #26809 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: BridgeAR

lib/url.js

@@ -359,9 +359,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost){
 
 // validate a little.
 if(!ipv6Hostname){
-constresult=validateHostname(this,rest,hostname);
-if(result!==undefined)
-rest=result;
+rest=getHostname(this,rest,hostname);
 }
 
 if(this.hostname.length>hostnameMaxLen){
@@ -462,7 +460,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost){
 returnthis;
 };
 
-functionvalidateHostname(self,rest,hostname){
+functiongetHostname(self,rest,hostname){
 for(vari=0;i<hostname.length;++i){
 constcode=hostname.charCodeAt(i);
 constisValid=(code>=CHAR_LOWERCASE_A&&code<=CHAR_LOWERCASE_Z)||
@@ -477,9 +475,10 @@ function validateHostname(self, rest, hostname){
 // Invalid host character
 if(!isValid){
 self.hostname=hostname.slice(0,i);
-return'/'+hostname.slice(i)+rest;
+return`/${hostname.slice(i)}${rest}`;
 }
 }
+returnrest;
 }
 
 // Escaped characters. Use empty strings to fill up unused entries.