test: refactor test-http-exit-delay

test-http-exit-delay was introduced to confirm the removal of a 1 second delay that can occur when exiting node after an http request. This change refactors the test for simplicity and also in the hopes of either eliminating flakiness on CI or, if not that, at least making the source of the flakiness easier to track down. Ref: 16b59cbcFixes: #4045 PR-URL: #4055 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Trott

test/parallel/test-http-exit-delay.js

@@ -1,41 +1,30 @@
 'use strict';
-varassert=require('assert');
-varcommon=require('../common');
-varhttp=require('http');
+constassert=require('assert');
+constcommon=require('../common');
+consthttp=require('http');
 
 varstart;
-varserver=http.createServer(function(req,res){
+constserver=http.createServer(common.mustCall(function(req,res){
 req.resume();
 req.on('end',function(){
 res.end('Success');
 });
 
 server.close();
-});
-
-server.listen(common.PORT,'localhost',function(){
-varinterval_id=setInterval(function(){
-start=newDate();
-if(start.getMilliseconds()>100)
-return;
-
-console.log(start.toISOString());
-varreq=http.request({
-'host': 'localhost',
-'port': common.PORT,
-'agent': false,
-'method': 'PUT'
-});
+}));
 
-req.end('Test');
-clearInterval(interval_id);
-},10);
-});
+server.listen(common.PORT,'localhost',common.mustCall(function(){
+start=newDate();
+constreq=http.request({
+'host': 'localhost',
+'port': common.PORT,
+'agent': false,
+'method': 'PUT'
+});
+req.end('Test');
+}));
 
 process.on('exit',function(){
-varend=newDate();
-console.log(end.toISOString());
-assert.equal(start.getSeconds(),end.getSeconds());
-assert(end.getMilliseconds()<900);
-console.log('ok');
+constend=newDate();
+assert(end-start<1000,'Entire test should take less than one second');
 });