http2: use addAbortListener

atlowChemi · ruyadorno · commit be88f7cd2200 · 2023-09-16T15:46:50.000-04:00
PR-URL: #48550 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -27,6 +27,7 @@ const{
 SafeSet,
 StringPrototypeSlice,
 Symbol,
+ SymbolDispose,
 TypedArrayPrototypeGetLength,
 Uint32Array,
 Uint8Array,
@@ -1810,10 +1811,8 @@ class ClientHttp2Session extends Http2Session{
 if (signal.aborted){
 aborter();
 } else{
- signal.addEventListener('abort', aborter);
- stream.once('close', () =>{
- signal.removeEventListener('abort', aborter);
- });
+ const disposable = EventEmitter.addAbortListener(signal, aborter);
+ stream.once('close', disposable[SymbolDispose]);
 }
 }
 

-Original file line number
+Diff line change
  SafeSet,
  StringPrototypeSlice,
  Symbol,
 + SymbolDispose,
  TypedArrayPrototypeGetLength,
  Uint32Array,
  Uint8Array,
 if(signal.aborted){
 aborter();
 }else{
 -signal.addEventListener('abort',aborter);
 -stream.once('close',()=>{
 -signal.removeEventListener('abort',aborter);
 -});
 +constdisposable=EventEmitter.addAbortListener(signal,aborter);
 +stream.once('close',disposable[SymbolDispose]);
+}
+}