Commit bebd7b2
test: fix flaky test-gc-net-timeout
There's a global.gc() invoked in an interval, and a second one in a req.setTimeout() callback. Remove the one in the callback. I'm not sure how competing global.gc() calls might result in a deadlock, but it seems plausible and empirical testing confirms that it makes the test reliable. Fixes: #23067 PR-URL: #23139 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>1 parent efeb49d commit bebd7b2
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | 44 | | |
46 | 45 | | |
47 | 46 | | |
| |||
0 commit comments